fix: compatiblity with oci/node:24-trixie image #58

Merged
mfenniak merged 1 commit from fix-trixie into main 2026-05-23 02:14:54 +00:00
Owner

Cascading with the node:24-trixie image is currently broken with errors like this:

/var/run/act/actions/f7/d999174e0804a9c67973c6a42c596e7a8fb286b0f669b96d010703a3b45072/cascading-pr.sh:26: repo_curl:  forgejo-curl.sh api_json https://code.forgejo.org/api/v1/repos/xorm/xorm/pulls/110
curl: option -H: error encountered when reading a file
curl: try 'curl --help' or 'curl --manual' for more information

The cause of this is the unconditional usage of HEADER_TOKEN="-H @$DOT_FORGEJO_CURL/header-token". If the header-token file isn't present because the login command hasn't been executed yet, then all access to api fails with this curl error. This seems to be a behaviour change in curl between bookworm -> trixie -- -H @somefile will fail rather than result in zero headers if the file is missing.

It's probably possible to fix this by changing the time that cascade performs the login, but a conditional check on whether the file is present or not before including the -H parameter seems like a safe and simple approach.

Partially tested in an offline environment, and it gets past the current error point -- haven't been able to fully test end-to-end due to the complexity of environmental setup required for cascade.

Cascading with the `node:24-trixie` image is currently broken with errors like this: ``` /var/run/act/actions/f7/d999174e0804a9c67973c6a42c596e7a8fb286b0f669b96d010703a3b45072/cascading-pr.sh:26: repo_curl: forgejo-curl.sh api_json https://code.forgejo.org/api/v1/repos/xorm/xorm/pulls/110 curl: option -H: error encountered when reading a file curl: try 'curl --help' or 'curl --manual' for more information ``` The cause of this is the unconditional usage of `HEADER_TOKEN="-H @$DOT_FORGEJO_CURL/header-token"`. If the `header-token` file isn't present because the `login` command hasn't been executed yet, then all access to `api` fails with this `curl` error. This seems to be a behaviour change in curl between bookworm -> trixie -- `-H @somefile` will fail rather than result in zero headers if the file is missing. It's probably possible to fix this by changing the time that cascade performs the login, but a conditional check on whether the file is present or not before including the `-H` parameter seems like a safe and simple approach. Partially tested in an offline environment, and it gets past the current error point -- haven't been able to fully test end-to-end due to the complexity of environmental setup required for cascade.
fix: compatiblity with node:24-trixie
All checks were successful
integration / integration (pull_request) Successful in 18m26s
96a0f8434e
mfenniak deleted branch fix-trixie 2026-05-23 02:14:54 +00:00
viceice approved these changes 2026-05-25 07:24:52 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
actions/cascading-pr!58
No description provided.