feat: new parameter download-pattern to only download matching asset files #109

fuse314 · 2025-12-04T12:48:13Z

fuse314 commented

2025-12-04 12:48:13 +00:00

First-time contributor

closes #103

fuse314 added 2 commits

2025-12-04 12:48:14 +00:00

feat: new parameter download-filter a17d224780

fix: syntax error

/ integration (pull_request) Has been cancelled

Details

/ tests (pull_request) Has been cancelled

Details

63c75028f3

crueter requested changes

2025-12-04 17:25:09 +00:00

action.yml Outdated

					
				@ -38,6 +38,8 @@ inputs:

				  download-latest:

				    description: 'Download the latest release'

				    default: false

				  download-filter:

To match download-artifact, a better solution might be to do pattern (globs) and name (single artifact)

To match download-artifact, a better solution might be to do `pattern` (globs) and `name` (single artifact)

good point. Renamed parameter to download-pattern.

good point. Renamed parameter to `download-pattern`.

fuse314 marked this conversation as resolved

forgejo-release.sh Outdated

					
				@ -19,6 +20,8 @@ if ${VERBOSE:-false}; then set -x; fi

				: ${RETRY:=1}

				: ${DELAY:=10}

				IFS=',' read -a DL_FILTER <<< "$DOWNLOAD_FILTER"

<<< is not POSIX compliant, nor is read -a. iirc POSIX handles newlines in for loops, but if not, you can do a simple tr to fix that. Comma separation should be avoided since users will input as:

pattern: pattern/1/* pattern2*

Or:

pattern: |
    pattern/1/*
    pattern2*

`<<<` is not POSIX compliant, nor is `read -a`. iirc POSIX handles newlines in for loops, but if not, you can do a simple tr to fix that. Comma separation should be avoided since users will input as: `pattern: pattern/1/* pattern2*` Or: ```yaml pattern: | pattern/1/* pattern2* ```

fuse314 marked this conversation as resolved

forgejo-release.sh Outdated

					
				@ -205,0 +216,4 @@

				            fi

				        done

				    fi

				    return 1

Please avoid arrays and [[ if possible.

download_asset() {
    name="$1"
    url="$2"
    
    curl --fail -H "Authorization: token $TOKEN" -o "$name" -L "$url"
}

maybe_download() {
    name="$1"
    url="$2"
    
    if [ -z "$DL_FILTER" ]; then
        download_asset "$@"
    else
        for filt in $DL_FILTER; do
            case "$name" in
                $filt) download_asset "$@" ;;
            esac
        done
    fi
}

Please avoid arrays and `[[` if possible. ```sh download_asset() { name="$1" url="$2" curl --fail -H "Authorization: token $TOKEN" -o "$name" -L "$url" } maybe_download() { name="$1" url="$2" if [ -z "$DL_FILTER" ]; then download_asset "$@" else for filt in $DL_FILTER; do case "$name" in $filt) download_asset "$@" ;; esac done fi } ```

Amazing! I did not know that case implements pattern-matching!
So much simpler.

Amazing! I did not know that case implements pattern-matching! So much simpler.

🚀 1

fuse314 marked this conversation as resolved

forgejo-release.sh Outdated

					
				@ -218,3 +235,2 @@

				        jq --raw-output '.assets[] | "\(.browser_download_url) \(.name)"' <"$TMP_DIR"/assets.json | while read url name; do # `name` may contain whitespace, therefore, it must be last

				            url=$(echo "$url" | sed "s#/download/${TAG}/#/download/${TAG_URL}/#")

				            curl --fail -H "Authorization: token $TOKEN" -o "$name" -L "$url"

				            if maybe_download "$name" ; then

If you use the previous function, we can just do maybe_download "$name" "$url"

If you use the previous function, we can just do `maybe_download "$name" "$url"`

fuse314 marked this conversation as resolved

fuse314 added 1 commit

2025-12-05 21:57:23 +00:00

feat: rename download-filter to download-pattern, implement pattern matching and improve action output

/ integration (pull_request) Has been cancelled

Details

/ tests (pull_request) Has been cancelled

Details

1b139d6f59

crueter reviewed

2025-12-06 08:00:31 +00:00

forgejo-release.sh Outdated

					
				@ -205,0 +223,4 @@

				        for pattern in $DOWNLOAD_PATTERN; do

				            case "$name" in

				                $pattern)

				                    if [ $downloaded == 1 ]; then

== is a ksh extension. Luckily, = does the same thing and is POSIX compliant 😁

Btw, the downloaded thing may not even be necessary. You can just return when a download is called, and I don't think mentioning ignored files is actually necessary? or maybe it is. I say we leave that to the actual maintainers and not some random weirdo like me :P

`==` is a ksh extension. Luckily, = does the same thing and is POSIX compliant 😁 Btw, the downloaded thing may not even be necessary. You can just `return` when a download is called, and I don't think mentioning ignored files is actually necessary? or maybe it is. I say we leave that to the actual maintainers and not some random weirdo like me :P

fuse314 marked this conversation as resolved

fuse314 changed title from ~~feat: new parameter download-filter to only download some asset files~~ to feat: new parameter download-pattern to only download matching asset files

2025-12-10 05:01:10 +00:00

fuse314 added 1 commit

2026-01-19 05:33:37 +00:00

fix: syntax

/ integration (pull_request) Has been cancelled

Details

/ tests (pull_request) Has been cancelled

Details

60d39d774b