Fix escaping, multiline release notes #82

Open

Mynacol wants to merge 3 commits from Mynacol/forgejo-release:main into main

Mynacol commented

2025-08-08 08:32:14 +00:00

Contributor

I wanted to use this action and encountered multiple bugs. This PR fixes all of them and massively improves the script regarding shellcheck warnings and notices.
Please cherry-pick if you don't want to have everything.

I wanted to use this action and encountered multiple bugs. This PR fixes all of them and massively improves the script regarding shellcheck warnings and notices. Please cherry-pick if you don't want to have everything.

Mynacol added 3 commits

2025-08-08 08:32:14 +00:00

Escape shell variables 31e2907aa0

I might have faced a problem caused by multiline release notes.
Irrespective of that, this commit fixes most of the shellcheck warnings.

At the tea invocation, `releaseType` may not be quoted to avoid an empty
argument for stable releases.

Update Tea version 3062a1a0f1

To potentially fix the problem:
`Error: ambiguous arguments: provide tagname via --tag or argument, but not both`

Move release notes to the end

/ integration (pull_request) Has been cancelled

Details

b2fef4bfa0

To avoid issues with complex/multiline release notes.

earl-warren commented

2025-08-10 10:18:47 +00:00

Owner

           release-notes: |
             - [User guide](https://forgejo.org/docs/next/user/actions/overview/)
             - [Administrator guide](https://forgejo.org/docs/next/admin/actions/)
             - [Container images](https://code.forgejo.org/forgejo/-/packages/container/runner/versions)
             Release Notes
             ---
           release-notes-assistant: true

is using (indirectly) multiline release notes. Could you please file an issue with a reproducer for the problem you had? Other improvements should be filed as separate pull requests and verified to pass the tests.

https://code.forgejo.org/forgejo/runner/src/commit/7a31b6a55e16ae2ddaf6523e7737ccdaa6d6a316/.forgejo/workflows/publish-release.yml#L40-L49 is using (indirectly) multiline release notes. Could you please file an issue with a reproducer for the problem you had? Other improvements should be filed as separate pull requests and verified to pass the tests.