feat: allow for draft releases #99

Open

crueter wants to merge 1 commit from crueter/forgejo-release:draft into main

crueter commented

2025-11-12 02:20:06 +00:00

Contributor

Closes #56.

Adds a draft input that, if true, skips the step of setting the draft
status to false.

Signed-off-by: crueter crueter@eden-emu.dev

Closes #56. Adds a `draft` input that, if true, skips the step of setting the draft status to false. Signed-off-by: crueter <crueter@eden-emu.dev>

👍 1

crueter added 1 commit

2025-11-12 02:20:06 +00:00

feat: allow for draft releases

/ tests (pull_request) Successful in 8s

Details

/ integration (pull_request) Successful in 19m6s

Details

0bca42135c

Closes #56.

Adds a `draft` input that, if true, skips the step of setting the draft
status to false.

Signed-off-by: crueter <crueter@eden-emu.dev>

randysimons commented

2026-01-01 16:45:53 +00:00

First-time contributor

If I set draft: false, the action succeeds - resulting in a non-draft release. See https://codeberg.org/randysimons/komplete-konfigure/actions/runs/28/jobs/0/attempt/1

If draft: true, the expression [ "$DRAFT" = "false" ] && release_draft false resolves to false . Could that be the problem, and that a regular if would fix it?

Well, this PR works in that it produces a new draft-release, but then the action simply fails. See https://codeberg.org/randysimons/komplete-konfigure/actions/runs/27/jobs/0/attempt/1#jobstep-7-79 (result of workflow https://codeberg.org/randysimons/komplete-konfigure/src/commit/63f837610721fcdcb4d592a830fcf99dcb35f535f94136b7c2a817c3b7ddab5e/.forgejo/workflows/release.yaml#L42) If I set `draft: false`, the action succeeds - resulting in a non-draft release. See https://codeberg.org/randysimons/komplete-konfigure/actions/runs/28/jobs/0/attempt/1 If `draft: true`, the expression ` [ "$DRAFT" = "false" ] && release_draft false` resolves to `false` . Could that be the problem, and that a regular `if` would fix it?

crueter commented

2026-01-01 17:01:30 +00:00

Author

Contributor

The proper solution would be [ "$DRAFT" != "false" ] || <set to draft>. I'll change that in a bit

The proper solution would be `[ "$DRAFT" != "false" ] || <set to draft>`. I'll change that in a bit