actions/setup-forgejo
actions/setup-forgejo
4
6
Fork 6
Code Issues 8 Pull requests 6 Releases 8 Activity Actions

fix: missing runner labels #221

Merged
earl-warren merged 1 commit from feat/additional-runner-labels into main 2024-12-07 08:39:46 +00:00
Conversation 3 Commits 1 Files changed 1 +2 -1
viceice commented 2024-12-06 17:06:00 +00:00
Owner
Copy link

The runner needs the new common labels for proper e2e testing

The runner needs the new common labels for proper e2e testing
👍 1
feat: additional runner labels
All checks were successful
/ integration (map[image:codeberg.org/forgejo/forgejo version:1.20]) (pull_request) Successful in 1m25s
Details
/ integration-action (pull_request) Successful in 4m39s
Details
/ integration (map[image:codeberg.org/forgejo/forgejo version:1.21]) (pull_request) Successful in 1m20s
Details
/ binary (pull_request) Successful in 1m12s
Details
/ cascade (pull_request_target) Successful in 6s
Details
73dd2153fd
cascading-pr commented 2024-12-06 17:13:04 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/end-to-end#389

cascading-pr updated at https://code.forgejo.org/forgejo/end-to-end/pulls/389
earl-warren requested changes 2024-12-07 08:19:41 +00:00
Dismissed
forgejo-runner.sh
@ -36,3 +36,3 @@
(
cd $DIR
timeout --signal=KILL 30 $DIR/forgejo-runner register --no-interactive --instance "$forgejo" --name runner --token $(cat $DIR/forgejo-runner-token) --labels docker:docker://code.forgejo.org/oci/node:20-bookworm,ubuntu-latest:docker://code.forgejo.org/oci/node:20-bookworm,self-hosted:lxc://debian:bookworm
timeout --signal=KILL 30 $DIR/forgejo-runner register --no-interactive --instance "$forgejo" --name runner --token $(cat $DIR/forgejo-runner-token) \
earl-warren commented 2024-12-07 08:19:38 +00:00
Contributor
Copy link

Can this be moved to the config file instead? This dates back from before the runner read the labels from the config file and it is less flexible.

Can this be moved to the [config file](https://code.forgejo.org/actions/setup-forgejo/src/commit/44a618a78ff4b1395ba4c6a70df97d0354c76622/runner-config.yaml#L12) instead? This dates back from before the runner read the labels from the config file and it is less flexible.
viceice commented 2024-12-07 08:28:26 +00:00
Author
Owner
Copy link

can we do it in a follow up PR and also fix #222?

can we do it in a follow up PR and also fix #222?
earl-warren commented 2024-12-07 08:39:17 +00:00
Contributor
Copy link

if you prefer

if you prefer
viceice commented 2024-12-07 08:59:04 +00:00
Author
Owner
Copy link

yes, will do next days 🤗

yes, will do next days 🤗
earl-warren marked this conversation as resolved
viceice changed title from feat: additional runner labels to fix: additional runner labels 2024-12-07 08:28:38 +00:00
viceice changed title from fix: additional runner labels to fix: missing runner labels 2024-12-07 08:28:48 +00:00
earl-warren deleted branch feat/additional-runner-labels 2024-12-07 08:39:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
actions/setup-forgejo!221
No description provided.