refactor: rename values key with compat #1357
No reviewers
earl-warren
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Question
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Help wanted
Status
In progress
Status
Need More Info
Status
Needs feedback
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
forgejo-helm/forgejo-helm!1357
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/rename-settings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There is a compat level to still support the
giteakey, so no breaking change.closes #80
depends on #1356 (should be merged after)
Did you test this on existing installations? In my first attempt this wasn't "so easy" unfortunately, but maybe I also overlooked something.
The main point is that you need to ensure important resources are not getting recreated (and by that in the worst case deleted if the reclaim policy is
Deleted) due to the renaming. Others are immutable after creation, which is another distinct problem.In my first tests I had issues with
existingClaimOne can of course account for all of these manually but this needs detailed migration instructions and initially I was trying to find a way to make this a seamless change instead.
ok, we'll shift this to v15. i like to get v14 out today
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.