fix: handle renamed first user in web UI #1523

Open

zugao wants to merge 1 commit from zugao/forgejo-helm:fix-admin-rename into main

pull from: zugao/forgejo-helm:fix-admin-rename

merge into: forgejo-helm:main

forgejo-helm:main

forgejo-helm:renovate/main-forgejo-16.x

forgejo-helm:refactor/rename-settings

forgejo-helm:refactor/rename-template-helper

forgejo-helm:refactor/forgejo-values

forgejo-helm:maint/v7

Conversation 1 Commits 1 Files changed 1 +25 -8

zugao commented 2026-04-08 09:25:07 +00:00

First-time contributor

Copy link

Copy Markdown

This PR addresses issue 1519

• closes #1519

This PR addresses [issue 1519](https://code.forgejo.org/forgejo-helm/forgejo-helm/issues/1519) - closes #1519

zugao force-pushed fix-admin-rename from d413e5ef0e to e4f639b7d5 2026-04-08 09:26:44 +00:00 Compare

zugao force-pushed fix-admin-rename from e4f639b7d5 to b40c93df8f 2026-04-08 09:27:41 +00:00 Compare

viceice changed title from Fix error on admin rename in Web UI to fix: handle renamed first user in web UI 2026-04-08 13:49:08 +00:00

viceice requested changes 2026-04-08 13:57:36 +00:00

viceice left a comment

Copy link

Copy Markdown

we should search the user by email if not found and if it exists emit a warning and don't do any further changes to the admin account

we should search the user by email if not found and if it exists emit a warning and don't do any further changes to the admin account

Some checks are pending

Hide checks

build / lint-node (pull_request) Blocked by required conditions

Required

Details

build / lint-helm (pull_request) Blocked by required conditions

Required

Details

build / e2e (v1.28.15+k3s1) (pull_request) Blocked by required conditions

Required

Details

build / e2e (v1.34.6+k3s1) (pull_request) Blocked by required conditions

Required

Details

build / e2e (v1.35.3+k3s1) (pull_request) Blocked by required conditions

Required

Details

build / test-success (pull_request) Blocked by required conditions

Required

Details

build / publish (pull_request) Blocked by required conditions

Details

This pull request has changes requested by an official reviewer.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u fix-admin-rename:zugao-fix-admin-rename

git switch zugao-fix-admin-rename

Sign in to join this conversation.

Reviewers

No reviewers

viceice

Labels

Clear labels

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Question

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Help wanted

  

Status

In progress

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Needs feedback

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Question

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Help wanted

Status

In progress

Status

Need More Info

Status

Needs feedback

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

forgejo-helm/forgejo-helm!1523

No description provided.