forgejo/act
11
4
Fork 7
Code Issues 6 Pull requests 2 Actions Releases Activity

[FORGEJO] a network of "" is not the same as "host" #35

Merged
earl-warren merged 1 commit from earl-warren/act:wip-network into main 2024-03-24 11:58:35 +00:00
Conversation 7 Commits 1 Files changed 1 +1 -8
earl-warren commented 2024-03-24 11:11:15 +00:00
Owner
Copy link

The comment that introduced this change suggests it was motivated by a
border case by which the image would be empty. It is however unclear
why it should have any impact on how the network name is determined.

The hunk is reverted.

https://github.com/nektos/act/pull/1949/files#r1315163582

The comment that introduced this change suggests it was motivated by a border case by which the image would be empty. It is however unclear why it should have any impact on how the network name is determined. The hunk is reverted. https://github.com/nektos/act/pull/1949/files#r1315163582
earl-warren added 1 commit 2024-03-24 11:11:15 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 6m58s
Details
/ cascade (pull_request) Has been skipped
Details
09d179c15b
[FORGEJO] a network of "" is not the same as "host" 
The comment that introduced this change suggests it was motivated by a
border case by which the image would be empty. It is however unclear
why it should have any impact on how the network name is determined.

The hunk is reverted.

https://github.com/nektos/act/pull/1949/files#r1315163582
cascading-pr commented 2024-03-24 11:14:12 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#166

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/166
cascading-pr commented 2024-03-24 11:29:34 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#166

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/166
twenty-panda approved these changes 2024-03-24 11:35:54 +00:00
viceice approved these changes 2024-03-24 11:45:17 +00:00
viceice commented 2024-03-24 11:47:51 +00:00
Member
Copy link

should we upstream it? I think it's an issue there too.

should we upstream it? I think it's an issue there too.
earl-warren commented 2024-03-24 11:53:30 +00:00
Author
Owner
Copy link

Passed end to end.

Passed [end to end](https://code.forgejo.org/forgejo/end-to-end/actions/runs/946/jobs/2#jobstep-3-543).
🎉 1
earl-warren commented 2024-03-24 11:58:16 +00:00
Author
Owner
Copy link

should we upstream it? I think it's an issue there too.

I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.

> should we upstream it? I think it's an issue there too. I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.
earl-warren merged commit af0a149a4d into main 2024-03-24 11:58:35 +00:00
earl-warren deleted branch wip-network 2024-03-24 11:58:35 +00:00
viceice commented 2024-03-24 12:16:03 +00:00
Member
Copy link

should we upstream it? I think it's an issue there too.

I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.

plausible 👍

> > should we upstream it? I think it's an issue there too. > > I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens. plausible 👍
earl-warren commented 2024-03-24 12:42:37 +00:00
Author
Owner
Copy link

https://gitea.com/gitea/act/issues/99 is the corresponding discussion.

https://gitea.com/gitea/act/issues/99 is the corresponding discussion.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
twenty-panda
viceice
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/act#35
No description provided.
Delete branch "earl-warren/act:wip-network"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?