[BUG/FEAT] When a runner is removed, it should shut down / shut down after a number of failures #147

Open
opened 2024-01-21 09:13:25 +00:00 by voltagex · 1 comment

I removed a runner from the UI and forgot about it. I then noticed the runner binary was still running, logging fairly regularly

...
ERRO[2024-01-21T20:08:47+11:00] failed to fetch task error="unavailable: 502 Bad Gateway"
ERRO[2024-01-21T20:08:49+11:00] failed to fetch task error="unavailable: 502 Bad Gateway"
ERRO[2024-01-21T20:08:51+11:00] failed to fetch task error="unavailable: 502 Bad Gateway"
...

(cut out 10x the amount of logs for this example)

I think there should be a configurable retry, after which the runner shuts down, or at least a backoff.

I removed a runner from the UI and forgot about it. I then noticed the runner binary was still running, logging fairly regularly ``` ... ERRO[2024-01-21T20:08:47+11:00] failed to fetch task error="unavailable: 502 Bad Gateway" ERRO[2024-01-21T20:08:49+11:00] failed to fetch task error="unavailable: 502 Bad Gateway" ERRO[2024-01-21T20:08:51+11:00] failed to fetch task error="unavailable: 502 Bad Gateway" ... ``` (cut out 10x the amount of logs for this example) I think there should be a configurable retry, after which the runner shuts down, or at least a backoff.
earl-warren added the
Kind/Enhancement
label 2024-01-21 12:40:47 +00:00
Owner

Something like : after one week of non-interrupted failures, just stop 👍

Something like : after one week of non-interrupted failures, just stop 👍
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#147
No description provided.