bug: Daemon fails to start if .runner is read-only #548

New issue

Closed

opened 2025-04-27 21:14:55 +00:00 by jonzuka · 0 comments

jonzuka commented

2025-04-27 21:14:55 +00:00

Can you reproduce the bug on the Forgejo test instance?

Description

I am providing .runner as a read-only file to the container which runs the forgejo-runner.

INFO[2025-04-27T20:04:10Z] Starting runner daemon
INFO[2025-04-27T20:04:10Z] runner: aarch64-linux_01, with version: v6.3.1, with labels: [host docker], declared successfully
Error: failed to save runner config: open /etc/forgejo_runner/runner.json: read-only file system

The user Gusted from the matrix channel suggested that the code can be improved to not trigger a .runner rewrite if nothing has changed.

Forgejo Version

Runner Version

6.3

How are you running Forgejo?

Inside a Kubernetes container.

How are you running the Runner?

Inside a Kubernetes container together with podman for the docker socket.

Logs

No response

Workflow file

No response

### Can you reproduce the bug on the Forgejo test instance? No ### Description I am providing .runner as a read-only file to the container which runs the forgejo-runner. ``` INFO[2025-04-27T20:04:10Z] Starting runner daemon INFO[2025-04-27T20:04:10Z] runner: aarch64-linux_01, with version: v6.3.1, with labels: [host docker], declared successfully Error: failed to save runner config: open /etc/forgejo_runner/runner.json: read-only file system ``` The user Gusted from the matrix channel suggested that the code can be improved to not trigger a .runner rewrite if nothing has changed. ### Forgejo Version 11 ### Runner Version 6.3 ### How are you running Forgejo? Inside a Kubernetes container. ### How are you running the Runner? Inside a Kubernetes container together with podman for the docker socket. ### Logs _No response_ ### Workflow file _No response_

jonzuka added the

Kind/Bug

label

2025-04-27 21:14:55 +00:00