forgejo/runner
32
100
Fork
You've already forked runner
 107
Code Issues 36 Pull requests 14 Releases 93 Packages 1 Activity Actions 2

feat: validate --directory alternative to --repository to not clone #1008

Merged
earl-warren merged 1 commit from earl-warren/runner:wip-validate-repository into main 2025-09-17 16:40:31 +00:00
Conversation 1 Commits 1 Files changed 12 +293 -6
earl-warren commented 2025-09-17 11:03:51 +00:00
Contributor
Copy link

Resolves forgejo/forgejo-actions-feature-requests#51

Note to reviewers: while working on fixing the exit status of the validate command, a border case was discovered when using --clonedir . --repository . by which it will not find an action.yml file at the root of the directory. It will be easier to fix and test using a --directory option designed to use a pre-existing directory instead because it is not a border case but the most common case really.

  • features
    • PR: feat: validate --directory alternative to --repository to not clone
Resolves forgejo/forgejo-actions-feature-requests#51 --- Note to reviewers: while working on fixing the exit status of the validate command, a border case was discovered when using `--clonedir . --repository .` by which it will not find an `action.yml` file at the root of the directory. It will be easier to fix and test using a `--directory` option designed to use a pre-existing directory instead because it is not a border case but the most common case really. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - features - [PR](https://code.forgejo.org/forgejo/runner/pulls/1008): <!--number 1008 --><!--line 0 --><!--description ZmVhdDogdmFsaWRhdGUgLS1kaXJlY3RvcnkgYWx0ZXJuYXRpdmUgdG8gLS1yZXBvc2l0b3J5IHRvIG5vdCBjbG9uZQ==-->feat: validate --directory alternative to --repository to not clone<!--description--> <!--end release-notes-assistant-->
mfenniak approved these changes 2025-09-17 15:09:56 +00:00
mfenniak left a comment
Copy link

LGTM

LGTM
internal/app/cmd/validate.go Outdated
@ -190,1 +205,4 @@
validateCmd.MarkFlagsOneRequired("repository", "path", "directory")
validateCmd.MarkFlagsMutuallyExclusive("repository", "path")
validateCmd.MarkFlagsMutuallyExclusive("directory", "repository")
validateCmd.MarkFlagsMutuallyExclusive("directory", "clonedir")
mfenniak commented 2025-09-17 15:09:35 +00:00
Owner
Copy link

It seems like there might be a mutually exclusive option missing -- "path" & "directory"?

It seems like there might be a mutually exclusive option missing -- `"path"` & `"directory"`?
earl-warren commented 2025-09-17 16:30:01 +00:00
Author
Contributor
Copy link

Good catch.

Good catch.
earl-warren marked this conversation as resolved
earl-warren force-pushed wip-validate-repository from 061a06b01f
All checks were successful
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / validate mocks (pull_request) Successful in 53s
Details
checks / build and test (pull_request) Successful in 2m47s
Details
checks / runner exec tests (pull_request) Successful in 24s
Details
/ example-lxc-systemd (pull_request) Successful in 6m33s
Details
checks / runner integration tests (pull_request) Successful in 4m26s
Details
checks / integration tests (pull_request) Successful in 10m16s
Details
to 80ac66e10c
All checks were successful
issue-labels / release-notes (pull_request_target) Successful in 4s
Details
checks / validate mocks (pull_request) Successful in 48s
Details
checks / build and test (pull_request) Successful in 2m37s
Details
checks / runner exec tests (pull_request) Successful in 24s
Details
checks / runner integration tests (pull_request) Successful in 4m19s
Details
checks / integration tests (pull_request) Successful in 10m41s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 4s
Details
cascade / forgejo (pull_request_target) Successful in 1m49s
Details
2025-09-17 16:29:45 +00:00 Compare
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-09-17 16:32:03 +00:00
earl-warren deleted branch wip-validate-repository 2025-09-17 16:40:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
famfo
mfenniak
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
earl-warren
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#1002 feat: add pre-commit hook for validator
forgejo/runner
#1009 fix: forgejo-runner validate exit with error when validation fails
forgejo/runner
Reference
forgejo/runner!1008
No description provided.