fix: forgejo-runner validate exit with error when validation fails #1009

Merged

earl-warren merged 2 commits from earl-warren/runner:wip-validate into main 2025-09-18 06:52:20 +00:00

Conversation 3 Commits 2 Files changed 2 +55 -28

earl-warren commented 2025-09-17 13:43:40 +00:00

Contributor

Copy link

• bug fixes
  • PR: fix: forgejo-runner validate exit with error when validation fails

<!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1009): <!--number 1009 --><!--line 0 --><!--description Zml4OiBmb3JnZWpvLXJ1bm5lciB2YWxpZGF0ZSBleGl0IHdpdGggZXJyb3Igd2hlbiB2YWxpZGF0aW9uIGZhaWxz-->fix: forgejo-runner validate exit with error when validation fails<!--description--> <!--end release-notes-assistant-->

earl-warren added the

Kind/Bug

label 2025-09-17 13:43:40 +00:00

earl-warren self-assigned this 2025-09-17 13:43:40 +00:00

earl-warren changed title from fix: forgejo-runner validate exit on error when validation fails to WIP: fix: forgejo-runner validate exit on error when validation fails 2025-09-17 13:43:50 +00:00

earl-warren added a new dependency 2025-09-17 13:44:28 +00:00

#1008 feat: validate --directory alternative to --repository to not clone

earl-warren referenced this pull request 2025-09-17 13:45:26 +00:00

feat: add pre-commit hook for validator #1002

earl-warren added a new dependency 2025-09-17 13:45:56 +00:00

#1002 feat: add pre-commit hook for validator

Freso commented 2025-09-17 19:35:33 +00:00

Contributor

Copy link

Maybe “exit with error” instead of “on error”? It’s not very clear that this implements error codes for exits rather than exiting when validation fails (which it already does, once it’s done validating). :)

I glanced over the code too and didn’t spot any obvious flaws—but my Go-fu is not very strong and I didn’t look in‐depth to try and decipher what was going on in more detail. It doesn’t seem like any tests were added to check for non-zero exit codes though? Maybe I’m missing something.

Maybe “exit _with_ error” instead of “_on_ error”? It’s not very clear that this implements error codes for exits rather than exiting when validation fails (which it already does, once it’s done validating). :) I glanced over the code too and didn’t spot any obvious flaws—but my Go-fu is not very strong and I didn’t look in‐depth to try and decipher what was going on in more detail. It doesn’t seem like any tests were added to check for non-zero exit codes though? Maybe I’m missing something.

👍 1

earl-warren changed title from WIP: fix: forgejo-runner validate exit on error when validation fails to WIP: fix: forgejo-runner validate exit with error when validation fails 2025-09-18 06:33:13 +00:00

earl-warren force-pushed wip-validate from 2e2e084613 to 2e83c0662b 2025-09-18 06:38:08 +00:00 Compare

earl-warren changed title from WIP: fix: forgejo-runner validate exit with error when validation fails to fix: forgejo-runner validate exit with error when validation fails 2025-09-18 06:38:29 +00:00

earl-warren commented 2025-09-18 06:40:38 +00:00

Author

Contributor

Copy link

It doesn’t seem like any tests were added to check for non-zero exit codes though? Maybe I’m missing something.

The tests at #1009/files now have a message field set which is verified to be contained in the error returned by validation. It was previously expected to be empty, meaning no error returned.

The CLI library will exit on error if a non nil error is returned.

Maybe “exit with error” instead of “on error”?

Done.

> It doesn’t seem like any tests were added to check for non-zero exit codes though? Maybe I’m missing something. The tests at https://code.forgejo.org/forgejo/runner/pulls/1009/files#diff-3496cc8ea4728e33a9e503f5bf7db0201d1a37f8 now have a message field set which is verified to be contained in the error returned by validation. It was previously expected to be empty, meaning no error returned. The CLI library will exit on error if a non nil error is returned. > Maybe “exit with error” instead of “on error”? Done.

👍 1

earl-warren force-pushed wip-validate from 2e83c0662b to 8c6c089a65 2025-09-18 06:40:49 +00:00 Compare

earl-warren requested reviews from viceice, mfenniak 2025-09-18 06:41:23 +00:00

viceice approved these changes 2025-09-18 06:48:15 +00:00

earl-warren merged commit 797e0cd250 into main 2025-09-18 06:52:20 +00:00

earl-warren deleted branch wip-validate 2025-09-18 06:52:20 +00:00

earl-warren referenced this pull request from a commit 2025-09-18 06:52:21 +00:00

fix: forgejo-runner validate exit with error when validation fails (#1009)

Freso referenced this pull request from a commit 2025-09-18 09:41:50 +00:00

fix(pre-commit): don’t default `verbose` to on

Freso referenced this pull request 2025-09-18 09:46:28 +00:00

fix(pre-commit): don’t default verbose to on #1015

earl-warren referenced this pull request from a commit 2025-09-18 12:02:09 +00:00

fix(pre-commit): don’t default `verbose` to on (#1015)

viceice-bot referenced this pull request 2025-09-19 00:01:41 +00:00

Update forgejo-runner to v11.1.1 #1018

viceice-bot referenced this pull request from actions/setup-forgejo 2025-09-19 00:02:57 +00:00

Update dependency forgejo/runner to v11.1.1 #686

earl-warren referenced this pull request from a commit 2025-09-19 04:31:16 +00:00

Update forgejo-runner to v11.1.1 (#1018)

earl-warren referenced this pull request from a commit 2025-09-19 04:34:00 +00:00

Update dependency forgejo/runner to v11.1.1 (#686)

forgejo-mirror referenced this pull request from a commit 2025-09-19 05:01:26 +00:00

Update module code.forgejo.org/forgejo/runner/v11 to v11.1.1 (forgejo) (#9354)

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

viceice

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

earl-warren

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#1002 feat: add pre-commit hook for validator

forgejo/runner

Depends on

#1008 feat: validate --directory alternative to --repository to not clone

forgejo/runner

Reference

forgejo/runner!1009

No description provided.