forgejo/runner
Watch
37
104
Fork
You've already forked runner
 110
Code Issues 35 Pull requests 13 Releases 96 Packages 1 Activity Actions

fix(pre-commit): don’t default verbose to on #1015

Merged
earl-warren merged 1 commit from Freso/forgejo-runner:pre-commit-verbose into main 2025-09-18 12:02:08 +00:00
Conversation 1 Commits 1 Files changed 1 -3
Freso commented 2025-09-18 09:46:28 +00:00
Contributor
Copy link
Copy Markdown

verbose was only set here as a work-around to make sure users saw the output of validate since there was no fail signal from the executable.

As of #1009 there now is a signal that the validation failed which pre-commit can pick up on, so we no longer need to default verbose to be on.

  • bug fixes
    • PR: fix(pre-commit): don’t default verbose to on
`verbose` was only set here as a work-around to make sure users saw the output of `validate` since there was no fail signal from the executable. As of https://code.forgejo.org/forgejo/runner/pulls/1009 there now is a signal that the validation failed which pre-commit can pick up on, so we no longer need to default `verbose` to be on. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1015): <!--number 1015 --><!--line 0 --><!--description Zml4KHByZS1jb21taXQpOiBkb27igJl0IGRlZmF1bHQgYHZlcmJvc2VgIHRvIG9u-->fix(pre-commit): don’t default `verbose` to on<!--description--> <!--end release-notes-assistant-->
fix(pre-commit): don’t default verbose to on
Some checks failed
checks / validate pre-commit-hooks file (pull_request) Successful in 58s
Details
checks / validate mocks (pull_request) Successful in 1m28s
Details
checks / build and test (pull_request) Successful in 3m36s
Details
checks / runner exec tests (pull_request) Successful in 31s
Details
checks / runner integration tests (pull_request) Successful in 4m30s
Details
checks / integration tests (pull_request) Successful in 12m9s
Details
cascade / forgejo (pull_request_target) Failing after 10m17s
Details
issue-labels / release-notes (pull_request_target) Failing after 12m18s
Details
cascade / end-to-end (pull_request_target) Successful in 36s
Details
cascade / debug (pull_request_target) Failing after 14m54s
Details
27b010989c
 
`verbose` was only set here as a work-around to make sure users saw the
output of `validate` since there was no fail signal from the executable.

As of #1009 there now is a
signal that the validation failed which pre-commit can pick up on, so we
no longer need to default `verbose` to be on.
earl-warren deleted branch pre-commit-verbose 2025-09-18 12:02:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1015
No description provided.