fix: modifying a cache secret does not invalidate cached entries #1043

Merged

earl-warren merged 1 commit from earl-warren/runner:wip-cache-invalidate into main 2025-10-01 16:38:38 +00:00

Conversation 3 Commits 1 Files changed 1 +6 -11

earl-warren commented 2025-10-01 15:46:35 +00:00

Contributor

• Copy link
• Copy Markdown

Resolves forgejo/runner#1041

• bug fixes
  • PR: fix: modifying a cache secret does not invalidate cached entries

Resolves forgejo/runner#1041 <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1043): <!--number 1043 --><!--line 0 --><!--description Zml4OiBtb2RpZnlpbmcgYSBjYWNoZSBzZWNyZXQgZG9lcyBub3QgaW52YWxpZGF0ZSBjYWNoZWQgZW50cmllcw==-->fix: modifying a cache secret does not invalidate cached entries<!--description--> <!--end release-notes-assistant-->

earl-warren added the

Kind/Bug

Kind/Documentation

labels 2025-10-01 15:46:35 +00:00

earl-warren self-assigned this 2025-10-01 15:46:35 +00:00

earl-warren requested review from mfenniak 2025-10-01 15:57:28 +00:00

mfenniak approved these changes 2025-10-01 16:03:07 +00:00

mfenniak left a comment

• Copy link
• Copy Markdown

Looks good to me, concurs with my code analysis.

I wonder if secret should be moved to the Only used for the external cache server. section? For internal server usage I can't see any reason why it would be meaningful to configure it.

Looks good to me, concurs with my code analysis. I wonder if `secret` should be moved to the `Only used for the external cache server.` section? For internal server usage I can't see any reason why it would be meaningful to configure it.

earl-warren force-pushed wip-cache-invalidate from 5cbe927625 to 18e679e29c 2025-10-01 16:24:44 +00:00 Compare

earl-warren commented 2025-10-01 16:24:58 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Good idea, done.

Good idea, done.

earl-warren scheduled this pull request to auto merge when all checks succeed 2025-10-01 16:25:07 +00:00

earl-warren merged commit 01766ff4e2 into main 2025-10-01 16:38:38 +00:00

earl-warren deleted branch wip-cache-invalidate 2025-10-01 16:38:39 +00:00

earl-warren referenced this pull request from a commit 2025-10-01 16:38:40 +00:00

fix: modifying a cache secret does not invalidate cached entries (#1043)

2franix reviewed 2025-10-01 17:45:15 +00:00

internal/pkg/config/config.example.yaml

Show resolved Hide resolved

2franix commented 2025-10-01 17:45:08 +00:00

Contributor

• Copy link
• Copy Markdown

I may be missing the obvious but I'm still wondering how this secret secures the communication. That's why I don't understand what difference it makes to set an explicit secret (even if the cache server is external).

I may be missing the obvious but I'm still wondering _how_ this secret secures the communication. That's why I don't understand what difference it makes to set an explicit secret (even if the cache server is external).

earl-warren commented 2025-10-01 19:40:23 +00:00

Author

Contributor

• Copy link
• Copy Markdown

In the case of an internal server, the cache is spawned from the runner and they share the same secret to communicate. In the case of an external cache, the shared secret (via the config file) is how the external cache knows the request originates from the runner.

In the case of an internal server, the cache is spawned from the runner and they share the same secret to communicate. In the case of an external cache, the shared secret (via the config file) is how the external cache knows the request originates from the runner.

2franix commented 2025-10-01 19:42:43 +00:00

Contributor

• Copy link
• Copy Markdown

OK, got it now.

the cache is spawned from the runner and they share the same secret to communicate

That's the detail I overlooked.

Thanks!

OK, got it now. > the cache is spawned from the runner and they share the same secret to communicate That's the detail I overlooked. Thanks!

earl-warren marked this conversation as resolved

viceice-bot referenced this pull request 2025-10-04 00:01:56 +00:00

Update forgejo-runner to v11.1.2 #1055

viceice-bot referenced this pull request from actions/setup-forgejo 2025-10-04 00:02:07 +00:00

Update dependency forgejo/runner to v11.1.2 #704

earl-warren referenced this pull request from a commit 2025-10-04 11:15:32 +00:00

Update forgejo-runner to v11.1.2 (#1055)

viceice-bot referenced this pull request from actions/setup-forgejo 2025-10-20 00:05:49 +00:00

Update dependency forgejo/runner to v11.2.0 #727

viceice-bot referenced this pull request from actions/setup-forgejo 2025-11-05 00:02:42 +00:00

Update dependency forgejo/runner to v11.3.0 #736

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

earl-warren

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

forgejo/runner!1043

No description provided.