forgejo/runner
Watch
61
117
Fork
You've already forked runner
 117
Code Issues 48 Pull requests 11 Releases 100 Packages 1 Activity Actions

chore(cleanup): lxc-helpers does not need a global lock #1047

Merged
earl-warren merged 1 commit from limiting-factor/runner:wip-lxc-helpers into main 2025-10-03 16:15:43 +00:00
Conversation 3 Commits 1 Files changed 1 -2
limiting-factor commented 2025-10-02 19:12:23 +00:00
Contributor

Refs forgejo/lxc-helpers#8

  • other
    • PR: chore(cleanup): lxc-helpers does not need a global lock
- https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.1.1 has locking and atomicity - this lock was only good for when two release templates are populated simultaneously and not when it was interrupted Refs forgejo/lxc-helpers#8 <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1047): <!--number 1047 --><!--line 0 --><!--description Y2hvcmUoY2xlYW51cCk6IGx4Yy1oZWxwZXJzIGRvZXMgbm90IG5lZWQgYSBnbG9iYWwgbG9jaw==-->chore(cleanup): lxc-helpers does not need a global lock<!--description--> <!--end release-notes-assistant-->
chore(cleanup): lxc-helpers does not need a global lock
All checks were successful
checks / validate pre-commit-hooks file (pull_request) Successful in 35s
Details
checks / validate mocks (pull_request) Successful in 51s
Details
checks / build and test (pull_request) Successful in 2m34s
Details
checks / runner exec tests (pull_request) Successful in 21s
Details
checks / runner integration tests (pull_request) Successful in 4m18s
Details
checks / integration tests (pull_request) Successful in 10m19s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 5s
Details
issue-labels / release-notes (pull_request_target) Successful in 10s
Details
cascade / forgejo (pull_request_target) Successful in 2m49s
Details
a052408814
 
- https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.1.1 has
  locking and atomicity
- this lock was only good for when two release templates are
  populated simultaneously and not when it was interrupted

Refs forgejo/lxc-helpers#8
limiting-factor changed title from chore(cleanup): lxc-helpers does not need a global lock to WIP: chore(cleanup): lxc-helpers does not need a global lock 2025-10-02 19:12:52 +00:00
limiting-factor commented 2025-10-02 19:13:26 +00:00
Author
Contributor

Blocked by the upgrade to https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.1.1

Blocked by the upgrade to https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.1.1
cascading-pr commented 2025-10-02 21:07:35 +00:00
Contributor

cascading-pr updated at actions/setup-forgejo#698

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/698
earl-warren changed title from WIP: chore(cleanup): lxc-helpers does not need a global lock to chore(cleanup): lxc-helpers does not need a global lock 2025-10-03 16:15:13 +00:00
earl-warren deleted branch wip-lxc-helpers 2025-10-03 16:15:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mfenniak
earl-warren
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
limiting-factor
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1047
No description provided.