fix: remove LXC backend leftovers when the job completes #1054

Merged

earl-warren merged 1 commit from earl-warren/runner:wip-cleanup into main 2025-10-03 16:14:09 +00:00

Conversation 3 Commits 1 Files changed 3 +10 -11

earl-warren commented 2025-10-03 11:15:10 +00:00

Contributor

Copy link

Copy Markdown

• remove the root of the LXC container after destroying it, with sudo as it may contain files owned by root while the runner id is not root
• os.RemoveAll only for native host runs, it is no longer needed for the LXC backend
• remove the CleanUp function that is an indirection with no use

Resolves forgejo/runner#442

When running the test from a non-root user and without this fix, it fails as follow:

go test -v -count=1 -run='TestRunnerLXC' ./internal/app/run
=== RUN   TestRunnerLXC
...
time="2025-10-03T15:05:12+02:00" level=debug msg=stopHostEnvironment
time="2025-10-03T15:05:13+02:00" level=debug msg="HostEnvironment.Remove /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor"
time="2025-10-03T15:05:13+02:00" level=error msg="Error while stop job container FORGEJO-ACTIONS-TASK-0_WORKFLOW-3ede81fbc69d42e6db70bef5820490fc3e7dc4d9dcbfb64981f2d00f08a30d6e_JOB-job: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied"
=== NAME  TestRunnerLXC
    runner_test.go:469: 
        	Error Trace:	/home/earl-warren/software/runner/internal/app/run/runner_test.go:469
        	            				/home/earl-warren/software/runner/internal/app/run/runner_test.go:496
        	Error:      	Received unexpected error:
        	            	Error occurred running finally: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied (original error: <nil>)
        	Test:       	TestRunnerLXC
        	Messages:   	OK
=== NAME  TestRunnerLXC/OK
    testing.go:1679: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
=== NAME  TestRunnerLXC
    testing.go:1267: TempDir RemoveAll cleanup: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied
--- FAIL: TestRunnerLXC (6.84s)
    --- FAIL: TestRunnerLXC/OK (6.84s)
FAIL
FAIL	code.forgejo.org/forgejo/runner/v11/internal/app/run	6.847s
FAIL

• bug fixes
  • PR: fix: remove LXC backend leftovers when the job completes

- remove the root of the LXC container after destroying it, with sudo as it may contain files owned by root while the runner id is not root - os.RemoveAll only for native host runs, it is no longer needed for the LXC backend - remove the CleanUp function that is an indirection with no use Resolves forgejo/runner#442 When running the test from a non-root user and without this fix, it fails as follow: ``` go test -v -count=1 -run='TestRunnerLXC' ./internal/app/run === RUN TestRunnerLXC ... time="2025-10-03T15:05:12+02:00" level=debug msg=stopHostEnvironment time="2025-10-03T15:05:13+02:00" level=debug msg="HostEnvironment.Remove /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor" time="2025-10-03T15:05:13+02:00" level=error msg="Error while stop job container FORGEJO-ACTIONS-TASK-0_WORKFLOW-3ede81fbc69d42e6db70bef5820490fc3e7dc4d9dcbfb64981f2d00f08a30d6e_JOB-job: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied" === NAME TestRunnerLXC runner_test.go:469: Error Trace: /home/earl-warren/software/runner/internal/app/run/runner_test.go:469 /home/earl-warren/software/runner/internal/app/run/runner_test.go:496 Error: Received unexpected error: Error occurred running finally: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied (original error: <nil>) Test: TestRunnerLXC Messages: OK === NAME TestRunnerLXC/OK testing.go:1679: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test === NAME TestRunnerLXC testing.go:1267: TempDir RemoveAll cleanup: unlinkat /tmp/TestRunnerLXC1841090130/001/d29c1256e2912892/hostexecutor/some/directory/owned/by/root: permission denied --- FAIL: TestRunnerLXC (6.84s) --- FAIL: TestRunnerLXC/OK (6.84s) FAIL FAIL code.forgejo.org/forgejo/runner/v11/internal/app/run 6.847s FAIL ``` <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1054): <!--number 1054 --><!--line 0 --><!--description Zml4OiByZW1vdmUgTFhDIGJhY2tlbmQgbGVmdG92ZXJzIHdoZW4gdGhlIGpvYiBjb21wbGV0ZXM=-->fix: remove LXC backend leftovers when the job completes<!--description--> <!--end release-notes-assistant-->

earl-warren added the

Kind/Bug

label 2025-10-03 11:15:10 +00:00

earl-warren self-assigned this 2025-10-03 11:15:10 +00:00

earl-warren referenced this pull request 2025-10-03 11:16:57 +00:00

bug: LXC hostexecutor leaks #442

earl-warren force-pushed wip-cleanup from 3577b08471 to b4eb780122 2025-10-03 13:00:15 +00:00 Compare

earl-warren added the

run-end-to-end-tests

label 2025-10-03 13:17:03 +00:00

earl-warren changed title from WIP: fix: cleanup hostexecutor directory to WIP: fix: remove LXC backend leftovers when the job completes 2025-10-03 13:20:28 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2025-10-03 13:23:32 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1054/head to forgejo/runner-1054 #703

cascading-pr commented 2025-10-03 13:23:33 +00:00

Contributor

Copy link

Copy Markdown

cascading-pr updated at actions/setup-forgejo#703

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/703

earl-warren changed title from WIP: fix: remove LXC backend leftovers when the job completes to fix: remove LXC backend leftovers when the job completes 2025-10-03 15:00:20 +00:00

earl-warren requested reviews from limiting-factor, mfenniak 2025-10-03 15:00:34 +00:00

mfenniak approved these changes 2025-10-03 15:34:29 +00:00

mfenniak left a comment

Copy link

Copy Markdown

Looks good to me. I pulled down main, reproduced the issue, and then pulled the branch and ran through some tests with LXC & a host executor and had no cleanup errors.

The only leftovers in ~/.cache/act were from remote uses (eg. uses: actions/checkout@v3), which I imagine are expected to remain around for cache re-use?

Looks good to me. I pulled down main, reproduced the issue, and then pulled the branch and ran through some tests with LXC & a host executor and had no cleanup errors. The only leftovers in `~/.cache/act` were from remote `uses` (eg. `uses: actions/checkout@v3`), which I imagine are expected to remain around for cache re-use?

earl-warren commented 2025-10-03 16:13:34 +00:00

Author

Contributor

Copy link

Copy Markdown

@mfenniak wrote in #1054 (comment):

The only leftovers in ~/.cache/act were from remote uses (eg. uses: actions/checkout@v3), which I imagine are expected to remain around for cache re-use?

Yes. It would be quite problematic to re-clone them every time 😁

@mfenniak wrote in https://code.forgejo.org/forgejo/runner/pulls/1054#issuecomment-62236: > The only leftovers in `~/.cache/act` were from remote `uses` (eg. `uses: actions/checkout@v3`), which I imagine are expected to remain around for cache re-use? Yes. It would be quite problematic to re-clone them every time 😁

earl-warren merged commit 413a52605d into main 2025-10-03 16:14:09 +00:00

earl-warren referenced this pull request from a commit 2025-10-03 16:14:10 +00:00

fix: remove LXC backend leftovers when the job completes (#1054)

earl-warren deleted branch wip-cleanup 2025-10-03 16:14:10 +00:00

viceice-bot referenced this pull request 2025-10-20 00:04:37 +00:00

Update forgejo-runner to v11.2.0 #1097

viceice-bot referenced this pull request from actions/setup-forgejo 2025-10-20 00:05:49 +00:00

Update dependency forgejo/runner to v11.2.0 #727

forgejo-mirror referenced this pull request from a commit 2025-10-20 02:01:34 +00:00

Update module code.forgejo.org/forgejo/runner/v11 to v11.2.0 (forgejo) (#9759)

viceice-bot referenced this pull request from actions/setup-forgejo 2025-11-05 00:02:42 +00:00

Update dependency forgejo/runner to v11.3.0 #736

viceice-bot referenced this pull request 2025-11-05 02:31:23 +00:00

Update forgejo-runner to v11.3.0 #1121

mfenniak referenced this pull request from a commit 2025-11-05 02:44:47 +00:00

Update forgejo-runner to v11.3.0 (#1121)

Sign in to join this conversation.

Reviewers

No reviewers

limiting-factor

mfenniak

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

earl-warren

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

forgejo/runner!1054

No description provided.