chore(docs): clarify the behavior of [container].docker_host #1059
No reviewers
Labels
No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
forgejo/runner!1059
Loading…
Reference in a new issue
No description provided.
Delete branch "drewcassidy/runner:clarify-docker-host"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The description of
container.docker_hostwas misleading (and IMO the setting itself does too many things, see forgejo/forgejo-actions-feature-requests#58). I clarified the comments in the example config to clearly explain that it will mount the specified socket inside the job container, and give some example values[container].docker_host@ -179,2 +179,2 @@# overrides the docker client host with the specified one.# If "-" or "", an available docker host will automatically be found.# Overrides the docker host set by the DOCKER_HOST environment variable, and mounts on the job container.# If "-", no docker host will be mounted in the job containerIs there a reason for removing
""here?Yes, I checked the code and it only checks for "-", not an empty string
if containerDaemonSocket != "-" {True but...
if cfg.Container.DockerHost == "" {cfg.Container.DockerHost = "-"}isn't this setting a delight? An endless source of awe.
Clarify the behavior ofto chore(docs): clarify the behavior ofcontainer.docker_host[container].docker_hostCould you please reflect this change in the docs? 🙏 There should be a script to do that automatically but there is not.