forgejo/runner
Watch
61
117
Fork
You've already forked runner
 117
Code Issues 48 Pull requests 11 Releases 100 Packages 1 Activity Actions

fix: don't panic on cacheproxy startup failure #1067

Merged
earl-warren merged 1 commit from mfenniak/forgejo-runner:fix-cacheproxy-failure into main 2025-10-07 08:09:14 +00:00
Conversation 2 Commits 1 Files changed 2 +95 -2
mfenniak commented 2025-10-07 01:01:01 +00:00
Owner

In #1064 I theorized that a failure to start up the cache proxy server might cause it to still be registered as ACTIONS_CACHE_URL. It turns out to not be the case as it will just panic, since cacheProxy is nil. But regardless, it seems better to not panic and crash if the intent here is "cache will be disabled" as documented in the log message.

  • bug fixes
    • PR: fix: don't panic on cacheproxy startup failure
In #1064 I theorized that a failure to start up the cache proxy server might cause it to still be registered as `ACTIONS_CACHE_URL`. It turns out to not be the case as it will just panic, since `cacheProxy` is `nil`. But regardless, it seems better to not panic and crash if the intent here is "cache will be disabled" as documented in the log message. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1067): <!--number 1067 --><!--line 0 --><!--description Zml4OiBkb24ndCBwYW5pYyBvbiBjYWNoZXByb3h5IHN0YXJ0dXAgZmFpbHVyZQ==-->fix: don't panic on cacheproxy startup failure<!--description--> <!--end release-notes-assistant-->
mfenniak force-pushed fix-cacheproxy-failure from 9f92ae9d0e
Some checks failed
checks / validate pre-commit-hooks file (pull_request) Successful in 48s
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / validate mocks (pull_request) Failing after 1m6s
Details
checks / build and test (pull_request) Failing after 1m14s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
checks / runner integration tests (pull_request) Has been skipped
Details
checks / integration tests (pull_request) Successful in 12m6s
Details
to 1440b004cb
All checks were successful
checks / validate pre-commit-hooks file (pull_request) Successful in 43s
Details
checks / validate mocks (pull_request) Successful in 1m4s
Details
checks / build and test (pull_request) Successful in 3m13s
Details
checks / runner exec tests (pull_request) Successful in 29s
Details
checks / runner integration tests (pull_request) Successful in 4m58s
Details
checks / integration tests (pull_request) Successful in 11m26s
Details
issue-labels / release-notes (pull_request_target) Successful in 5s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 5s
Details
cascade / forgejo (pull_request_target) Successful in 1m35s
Details
2025-10-07 01:05:30 +00:00 Compare
cascading-pr commented 2025-10-07 01:10:02 +00:00
Contributor

cascading-pr updated at actions/setup-forgejo#711

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/711
mfenniak changed title from fix: disable cache on cacheproxy startup failure to fix: don't panic on cacheproxy startup failure 2025-10-07 02:24:37 +00:00
earl-warren deleted branch fix-cacheproxy-failure 2025-10-07 08:09:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1067
No description provided.