forgejo/runner
Watch
61
117
Fork
You've already forked runner
 117
Code Issues 48 Pull requests 11 Releases 100 Packages 1 Activity Actions

feat: allow --memory in workflow container options #1079

Merged
earl-warren merged 1 commit from earl-warren/runner:wip-resources into main 2025-10-10 14:33:07 +00:00
Conversation 5 Commits 1 Files changed 2 +174
earl-warren commented 2025-10-10 12:52:42 +00:00
Contributor

First hand experience to implement this feature can be found at https://codeberg.org/forgejo/forgejo/issues/9406. In a nutshell it is a service container in the CI that randomly uses massive amounts of memory (>50GB RSS) but normally less than 100MB.

See also the matching documentation pull request.

It is already possible to limit the memory used by all containers in the config file:

container:
  options: --memory 200M

This limit can be further reduced (but not increased) by the same option in a job:

jobs:
  job:
    runs-on: docker
    container:
      image: code.forgejo.org/oci/node:20-bookworm
      options: --memory 200M
    steps:
      - run: echo OK

or a service container:

job:
  my-job:
    runs-on: docker
    services:
      pgsql:
        image: postgres:15
        options: --memory 1G

Refs https://docs.docker.com/engine/containers/resource_constraints/#limit-a-containers-access-to-memory

  • features
    • PR: feat: allow --memory in workflow container options
First hand experience to implement this feature can be found at https://codeberg.org/forgejo/forgejo/issues/9406. In a nutshell it is a service container in the CI that randomly uses massive amounts of memory (>50GB RSS) but normally less than 100MB. --- See also the [matching documentation pull request](https://codeberg.org/forgejo/docs/pulls/1539). --- It is already possible to limit the memory used by all containers in the config file: ```yaml container: options: --memory 200M ``` This limit can be further reduced (but not increased) by the same option in a job: ```yaml jobs: job: runs-on: docker container: image: code.forgejo.org/oci/node:20-bookworm options: --memory 200M steps: - run: echo OK ``` or a service container: ```yaml job: my-job: runs-on: docker services: pgsql: image: postgres:15 options: --memory 1G ``` Refs https://docs.docker.com/engine/containers/resource_constraints/#limit-a-containers-access-to-memory <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - features - [PR](https://code.forgejo.org/forgejo/runner/pulls/1079): <!--number 1079 --><!--line 0 --><!--description ZmVhdDogYWxsb3cgLS1tZW1vcnkgaW4gd29ya2Zsb3cgY29udGFpbmVyIG9wdGlvbnM=-->feat: allow --memory in workflow container options<!--description--> <!--end release-notes-assistant-->
earl-warren force-pushed wip-resources from 6b2eb36b32
Some checks failed
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 1m22s
Details
checks / validate mocks (pull_request) Successful in 2m2s
Details
checks / build and test (pull_request) Failing after 2m7s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
checks / runner integration tests (pull_request) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
checks / integration tests (pull_request) Successful in 15m44s
Details
to f4d3a2c3a4
All checks were successful
checks / validate pre-commit-hooks file (pull_request) Successful in 58s
Details
checks / validate mocks (pull_request) Successful in 1m19s
Details
checks / build and test (pull_request) Successful in 1m31s
Details
checks / runner exec tests (pull_request) Successful in 40s
Details
checks / runner integration tests (pull_request) Successful in 5m48s
Details
checks / integration tests (pull_request) Successful in 12m14s
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 9s
Details
cascade / forgejo (pull_request_target) Successful in 1m2s
Details
2025-10-10 13:10:57 +00:00 Compare
cascading-pr commented 2025-10-10 13:27:09 +00:00
Contributor

cascading-pr updated at actions/setup-forgejo#715

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/715
cascading-pr commented 2025-10-10 13:28:59 +00:00
Contributor

cascading-pr updated at https://codeberg.org/forgejo/forgejo/pulls/9613

cascading-pr updated at https://codeberg.org/forgejo/forgejo/pulls/9613
viceice approved these changes 2025-10-10 13:39:34 +00:00
viceice left a comment

writing test was more complex than the implementation 😁

writing test was more complex than the implementation 😁
mfenniak approved these changes 2025-10-10 13:53:53 +00:00
earl-warren commented 2025-10-10 13:55:10 +00:00
Author
Contributor

Indeed, but not that much: most of the code is copy/pasted from other tests. There probably is enough to keep them DRY, adding helpers. But that will be fore another time.

Indeed, but not that much: most of the code is copy/pasted from other tests. There probably is enough to keep them DRY, adding helpers. But that will be fore another time.
earl-warren deleted branch wip-resources 2025-10-10 14:33:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
viceice
mfenniak
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
earl-warren
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1079
No description provided.