forgejo/runner
Watch
61
117
Fork
You've already forked runner
 117
Code Issues 48 Pull requests 11 Releases 100 Packages 1 Activity Actions

fix: lxc_exists_and_apt_not_old must be in a transaction #1104

Merged
earl-warren merged 1 commit from cascading-pr/runner:forgejo/lxc-helpers-52 into main 2025-10-20 21:03:14 +00:00
Conversation 3 Commits 1 Files changed 1 +8 -5
cascading-pr commented 2025-10-20 15:24:13 +00:00
Contributor

cascading-pr from forgejo/lxc-helpers#52

  • bug fixes
    • PR: fix: lxc_exists_and_apt_not_old must be in a transaction
cascading-pr from https://code.forgejo.org/forgejo/lxc-helpers/pulls/52 <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1104): <!--number 1104 --><!--line 0 --><!--description Zml4OiBseGNfZXhpc3RzX2FuZF9hcHRfbm90X29sZCBtdXN0IGJlIGluIGEgdHJhbnNhY3Rpb24=-->fix: lxc_exists_and_apt_not_old must be in a transaction<!--description--> <!--end release-notes-assistant-->
cascading-pr update
All checks were successful
checks / build and test (pull_request) Successful in 1m25s
Details
checks / validate mocks (pull_request) Successful in 1m1s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 46s
Details
checks / runner exec tests (pull_request) Successful in 52s
Details
checks / runner integration tests (pull_request) Successful in 9m20s
Details
checks / integration tests (pull_request) Successful in 18m0s
Details
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 10s
Details
cascade / forgejo (pull_request_target) Successful in 2m54s
Details
bff8797030
cascading-pr commented 2025-10-20 20:11:55 +00:00
Author
Contributor

cascading-pr updated at actions/setup-forgejo#729

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/729
limiting-factor changed title from cascading-pr from https://code.forgejo.org/forgejo/lxc-helpers refs/pull/52/head to forgejo/lxc-helpers-52 to fix: lxc_exists_and_apt_not_old must be in a transaction 2025-10-20 20:12:23 +00:00
earl-warren commented 2025-10-20 20:17:48 +00:00
Contributor

The end-to-end tests are not going to verify the bug is fixed. But running

forgejo/end-to-end#1149/files

manually on a brand new LXC container consistently fails without this fix and succeeds with it. Once the runner including this is in use by default in end-to-end it will guard against that kind of race in the future.

The end-to-end tests are not going to verify the bug is fixed. But running https://code.forgejo.org/forgejo/end-to-end/pulls/1149/files manually on a brand new LXC container consistently fails without this fix and succeeds with it. Once the runner including this is in use by default in end-to-end it will guard against that kind of race in the future.
earl-warren deleted branch forgejo/lxc-helpers-52 2025-10-20 21:03:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
limiting-factor
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1104
No description provided.