fix: after git clone for remote git actions & workflows, don't immediately git fetch repeating same work #1164

Closed

mfenniak wants to merge 6 commits from mfenniak/forgejo-runner:fix-double-fetch-on-repo-init into main

pull from: mfenniak/forgejo-runner:fix-double-fetch-on-repo-init

merge into: forgejo:main

forgejo:main

forgejo:renovate/github.com-docker-go-connections-0.x

forgejo:renovate/go-github.com-docker-cli-vulnerability

forgejo:renovate/forgejo-lxc-13.x

forgejo:validate-1460

forgejo:chore/testing-trixie

forgejo:chore/testing-bookworm

forgejo:expand-reusable-workflows-working-branch

forgejo:feat-default_actions_url-on-step

forgejo:2023-05-22-main-before-force-push

forgejo:2023-04-30-main-before-force-push

Conversation 2 Commits 6 Files changed 8 +448 -349

mfenniak commented 2025-11-19 21:48:59 +00:00

Owner

Copy link

(Stacked on #1162 -- 78b2252097 is the only relevant commit to this change)

Small optimization for when a repo cache is initialized to not clone then fetch. fetch still occurs usually.

• bug fixes
  • PR: fix: after git clone for remote git actions & workflows, don't immediately git fetch repeating same work

(Stacked on #1162 -- 78b22520974c547cc23edaab7f6f8a60b784e40b is the only relevant commit to this change) Small optimization for when a repo cache is initialized to not `clone` then `fetch`. `fetch` still occurs usually. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1164): <!--number 1164 --><!--line 0 --><!--description Zml4OiBhZnRlciBgZ2l0IGNsb25lYCBmb3IgcmVtb3RlIGdpdCBhY3Rpb25zICYgd29ya2Zsb3dzLCBkb24ndCBpbW1lZGlhdGVseSBgZ2l0IGZldGNoYCByZXBlYXRpbmcgc2FtZSB3b3Jr-->fix: after `git clone` for remote git actions & workflows, don't immediately `git fetch` repeating same work<!--description--> <!--end release-notes-assistant-->

mfenniak added 6 commits 2025-11-19 21:49:00 +00:00

chore: make cloneIfRequired internal e90ccd2cd3

refactor: remove 'Executor' model from git module 903823f75d

refactor: move repo directory management into the git module 46a1aadfd6

feat: use independent git worktree for remote git actions & workflows ca5590c777

chore: remove unnecessary Mutexes dd8e7427cb

fix: don't fetch repo immediately after cloning 78b2252097

mfenniak added the

run-end-to-end-tests

label 2025-11-19 21:49:47 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2025-11-19 21:50:06 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1164/head to forgejo/runner-1164 #766

cascading-pr commented 2025-11-19 21:50:07 +00:00

Contributor

Copy link

cascading-pr updated at actions/setup-forgejo#766

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/766

mfenniak changed title from fix: after git clone is successful, don't immediately git fetch repeating same work to fix: after git clone is successful for a step/reusable workflow, don't immediately git fetch repeating same work 2025-11-19 21:50:54 +00:00

mfenniak changed title from fix: after git clone is successful for a step/reusable workflow, don't immediately git fetch repeating same work to fix: after git clone for remote git actions & workflows, don't immediately git fetch repeating same work 2025-11-19 21:51:25 +00:00

mfenniak commented 2025-11-19 22:13:26 +00:00

Author

Owner

Copy link

Needs revision (if possible) as the fetch provides value in getting the non-default-branch references from the remote, even just after the clone.

Needs revision (if possible) as the fetch provides value in getting the non-default-branch references from the remote, even just after the clone.

mfenniak closed this pull request 2025-11-19 22:13:26 +00:00

Some checks are pending

Hide all checks

checks / validate pre-commit-hooks file (pull_request) Successful in 33s

Details

checks / validate mocks (pull_request) Successful in 46s

Details

checks / build and test (pull_request) Failing after 1m48s

Details

checks / runner exec tests (pull_request) Has been skipped

Required

Details

checks / runner integration tests (pull_request) Has been skipped

Details

issue-labels / release-notes (pull_request_target) Successful in 4s

Details

checks / integration tests (pull_request) Successful in 8m44s

Details

cascade / debug (pull_request_target) Has been skipped

Required

Details

cascade / forgejo (pull_request_target) Successful in 1m9s

Required

Details

cascade / end-to-end (pull_request_target) Successful in 31m0s

Required

Details

checks / Build Forgejo Runner *

Required

checks / Run integration tests with *

Required

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1164

No description provided.