forgejo/runner
32
100
Fork
You've already forked runner
 107
Code Issues 36 Pull requests 14 Releases 93 Packages 1 Activity Actions 2

fix: 'failed to read action' errors when using relative workdir_parent #1175

Merged
mfenniak merged 2 commits from mfenniak/forgejo-runner:fix-failed-to-read-action into main 2025-11-22 13:17:17 +00:00
Conversation 3 Commits 2 Files changed 4 +27 -1
mfenniak commented 2025-11-22 02:20:07 +00:00
Owner
Copy link

When workdir_parent is a relative path, actions were failing with error:

⚙️ [runner]: failed to read action 'Checkout', no files found after reading paths: action.yml, action.yaml, Dockerfile

The cause of this is that worktree creation using git -C relative/repodir worktree add relative/worktree would actually create the relative/worktree inside the repo. It seems that git -C to operate on a repo changes the working directory into that repo and evaluates relative paths from there.

Fixed by converting workdir_parent into an absolute path after the config file is read, and adding an error in the git operations if a relative path somehow makes its way through.

  • bug fixes
    • PR: fix: 'failed to read action' errors when using relative workdir_parent
When `workdir_parent` is a relative path, actions were failing with error: ``` ⚙️ [runner]: failed to read action 'Checkout', no files found after reading paths: action.yml, action.yaml, Dockerfile ``` The cause of this is that worktree creation using `git -C relative/repodir worktree add relative/worktree` would actually create the `relative/worktree` inside the repo. It seems that `git -C` to operate on a repo changes the working directory into that repo and evaluates relative paths from there. Fixed by converting `workdir_parent` into an absolute path after the config file is read, and adding an error in the git operations if a relative path somehow makes its way through. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1175): <!--number 1175 --><!--line 0 --><!--description Zml4OiAnZmFpbGVkIHRvIHJlYWQgYWN0aW9uJyBlcnJvcnMgd2hlbiB1c2luZyByZWxhdGl2ZSB3b3JrZGlyX3BhcmVudA==-->fix: 'failed to read action' errors when using relative workdir_parent<!--description--> <!--end release-notes-assistant-->
mfenniak force-pushed fix-failed-to-read-action from 0764ee1408
Some checks failed
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 30s
Details
checks / build and test (pull_request) Failing after 37s
Details
checks / validate mocks (pull_request) Successful in 33s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
checks / runner integration tests (pull_request) Has been skipped
Details
checks / integration tests (pull_request) Successful in 11m9s
Details
to 9744c5532a
All checks were successful
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 5s
Details
checks / validate mocks (pull_request) Successful in 33s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 33s
Details
checks / build and test (pull_request) Successful in 1m51s
Details
checks / runner exec tests (pull_request) Successful in 24s
Details
checks / runner integration tests (pull_request) Successful in 4m56s
Details
checks / integration tests (pull_request) Successful in 10m27s
Details
2025-11-22 02:22:05 +00:00 Compare
mfenniak force-pushed fix-failed-to-read-action from 9744c5532a
All checks were successful
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 5s
Details
checks / validate mocks (pull_request) Successful in 33s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 33s
Details
checks / build and test (pull_request) Successful in 1m51s
Details
checks / runner exec tests (pull_request) Successful in 24s
Details
checks / runner integration tests (pull_request) Successful in 4m56s
Details
checks / integration tests (pull_request) Successful in 10m27s
Details
to 6d791d30ff
All checks were successful
checks / validate mocks (pull_request) Successful in 36s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 35s
Details
checks / build and test (pull_request) Successful in 43s
Details
checks / runner exec tests (pull_request) Successful in 27s
Details
issue-labels / release-notes (pull_request_target) Successful in 4s
Details
checks / runner integration tests (pull_request) Successful in 5m12s
Details
checks / integration tests (pull_request) Successful in 10m18s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 6s
Details
cascade / forgejo (pull_request_target) Successful in 1m29s
Details
2025-11-22 02:28:00 +00:00 Compare
cascading-pr commented 2025-11-22 02:31:42 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#773

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/773
mfenniak commented 2025-11-22 02:32:25 +00:00
Author
Owner
Copy link

Regression caused by #1162.

Regression caused by #1162.
mfenniak deleted branch fix-failed-to-read-action 2025-11-22 13:17:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
limiting-factor
Labels
Clear labels   
FreeBSD

   
Kind/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Chore
It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate
for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Windows
Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le
powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests
Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests
Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  
run-multi-platform-tests
Label a PR for automatic execution of test suite on arm64 architecture.

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1175
No description provided.