forgejo/runner
12
29
Fork 21
Code Issues 39 Pull requests 1 Actions Packages Releases 26 Activity

feat(docker): Add flag to enable IPv6 in auto-created networks #120

Merged
earl-warren merged 3 commits from s3lph/forgejo-runner:feat-docker-ipv6 into main 2023-11-15 16:42:30 +00:00
Conversation 7 Commits 3 Files changed 6 +39 -31
s3lph commented 2023-11-14 18:20:25 +00:00
Contributor
Copy link

Implements one part of #119. The other part is a corresponding PR in forgejo/act: forgejo/act#24.

Closes #119

Implements one part of #119. The other part is a corresponding PR in forgejo/act: forgejo/act#24. Closes #119
s3lph added 1 commit 2023-11-14 18:20:26 +00:00
Some checks failed
/ cascade (pull_request) Failing after 3m19s
Details
checks / check and test (pull_request) Failing after 47s
Details
/ example-docker-compose (pull_request) Successful in 2m54s
Details
1139bb7d12 feat(docker): Add flag to enable IPv6 in auto-created networks
cascading-pr commented 2023-11-14 18:20:40 +00:00
First-time contributor
Copy link

cascading-pr updated at actions/setup-forgejo#102

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/102
s3lph commented 2023-11-14 18:49:25 +00:00
Author
Contributor
Copy link

The pipeline for this PR fails as it requires the changes from forgejo/act#24 to be merged first.

The pipeline for this PR fails as it requires the changes from forgejo/act#24 to be merged first.
👍 1
earl-warren commented 2023-11-14 22:07:56 +00:00
Owner
Copy link

ACT v1.17.0 was tagged just now with your change merged in. You can update this PR to upgrade to this version in go.mod.

Note that the CI of the runner does not do much more than compiling. But the cascading PRs your update will trigger in setup-forgejo and in end-to-end will run tests that verify your change is backward compatible and does not introduce a regression.

ACT v1.17.0 was tagged just now with your change merged in. You can update this PR to upgrade to this version in go.mod. Note that the CI of the runner does not do much more than compiling. But the cascading PRs your update will trigger [in setup-forgejo](https://code.forgejo.org/actions/setup-forgejo/pulls/102) and [in end-to-end](https://code.forgejo.org/forgejo/end-to-end/pulls/28) will run tests that verify your change is backward compatible and does not introduce a regression.
earl-warren added the
Kind/Feature
 label 2023-11-14 22:09:43 +00:00
earl-warren approved these changes 2023-11-14 22:10:02 +00:00
s3lph added 1 commit 2023-11-14 23:37:03 +00:00
Some checks failed
checks / check and test (pull_request) Failing after 1m12s
Details
/ example-docker-compose (pull_request) Successful in 1m56s
Details
/ cascade (pull_request) Successful in 13m28s
Details
863fb9c760 chore: update forgejo/act to v1.17.0
s3lph added 1 commit 2023-11-15 00:10:07 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 50s
Details
/ example-docker-compose (pull_request) Successful in 2m1s
Details
/ cascade (pull_request) Successful in 8s
Details
7db5a7f8d9 chore: make fmt
s3lph requested review from earl-warren 2023-11-15 00:19:26 +00:00
s3lph commented 2023-11-15 00:37:59 +00:00
Author
Contributor
Copy link

@earl-warren for some reason the cascading-pr CI trigger was skipped for my latest commits:

Skipping job 'cascade' due to 'vars.CASCADE != 'no''
@earl-warren for some reason the cascading-pr CI trigger was skipped for my latest commits: Skipping job 'cascade' due to 'vars.CASCADE != 'no''
cascading-pr commented 2023-11-15 11:08:34 +00:00
First-time contributor
Copy link

cascading-pr updated at actions/setup-forgejo#102

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/102
earl-warren commented 2023-11-15 11:08:59 +00:00
Owner
Copy link

Good catch, I removed the variable and kicked https://code.forgejo.org/forgejo/runner/actions/runs/627

Good catch, I removed the variable and kicked https://code.forgejo.org/forgejo/runner/actions/runs/627
earl-warren commented 2023-11-15 16:41:27 +00:00
Owner
Copy link

The cascade PRs both passed

The cascade PRs both passed * https://code.forgejo.org/actions/setup-forgejo/pulls/102/files * https://code.forgejo.org/forgejo/end-to-end/pulls/28/files
earl-warren approved these changes 2023-11-15 16:42:04 +00:00
earl-warren merged commit d22ee0fb8e into main 2023-11-15 16:42:30 +00:00
earl-warren deleted branch feat-docker-ipv6 2023-11-15 16:42:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#120
No description provided.
Delete branch "s3lph/forgejo-runner:feat-docker-ipv6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?