IPv6 tests #129

Merged
earl-warren merged 1 commit from earl-warren/runner:wip-ipv6 into main 2023-12-04 16:58:23 +00:00
Owner
No description provided.
earl-warren added the
Kind/Testing
label 2023-12-02 18:22:40 +00:00
earl-warren added 1 commit 2023-12-02 18:22:41 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
checks / check and test (pull_request) Successful in 57s
/ example-docker-compose (pull_request) Successful in 2m1s
7bbb083848
IPv6 tests
earl-warren force-pushed wip-ipv6 from 7bbb083848 to 2113010839 2023-12-02 19:29:44 +00:00 Compare
earl-warren force-pushed wip-ipv6 from 2113010839 to 82e7903cf6 2023-12-02 19:42:17 +00:00 Compare
earl-warren force-pushed wip-ipv6 from 82e7903cf6 to dfa5b40d08 2023-12-02 19:46:35 +00:00 Compare
earl-warren force-pushed wip-ipv6 from dfa5b40d08 to 6601916845 2023-12-02 19:48:20 +00:00 Compare
earl-warren force-pushed wip-ipv6 from 6601916845 to 5657be456b 2023-12-02 19:50:19 +00:00 Compare
dachary approved these changes 2023-12-02 19:52:05 +00:00
earl-warren force-pushed wip-ipv6 from 5657be456b to c7f32c976f 2023-12-02 20:02:41 +00:00 Compare
earl-warren force-pushed wip-ipv6 from c7f32c976f to 0d7c611eef 2023-12-02 20:10:02 +00:00 Compare
earl-warren force-pushed wip-ipv6 from 0d7c611eef to 226bf636e6 2023-12-02 20:16:03 +00:00 Compare
Author
Owner

@s3lph an extra pair of eyes would be much appreciated here. My biggest concern in this kind of tests is false positive.

@s3lph an extra pair of eyes would be much appreciated here. My biggest concern in this kind of tests is false positive.
First-time contributor

cascading-pr updated at actions/setup-forgejo#107

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/107
s3lph reviewed 2023-12-02 21:09:24 +00:00
@ -0,0 +8,4 @@
steps:
- run: |
apt update -qq ; apt --quiet install -qq --yes iputils-ping
ping -c 1 -6 ::1
Contributor

Do you want to verify whether the Forgejo Runner creates its networks with enable_ipv6: true? Or do you want to take it a step further and verify that IPv6 connectivity including ip6tables NAT actually works.

This localhost ping check suffices to do the former, but to achieve the latter, either a ping or (IMO better, as it also works with unprivileged Podman containers) curl to a public IPv6-only server such as ipv6.google.com is needed. An example for this can be found in my docs PR.

Do you want to verify whether the Forgejo Runner creates its networks with `enable_ipv6`: true? Or do you want to take it a step further and verify that IPv6 connectivity including ip6tables NAT actually works. This localhost ping check suffices to do the former, but to achieve the latter, either a ping or (IMO better, as it also works with unprivileged Podman containers) curl to a public IPv6-only server such as ipv6.google.com is needed. An example for this can be found [in my docs PR](https://forgejo.codeberg.page/@docs_pull_243/docs/v1.21/admin/actions/#enable-ipv6-in-docker--podman-networks).
Author
Owner

In this context, I think the simpler test is good enough as it demonstrates IPv6 is enabled. For the other part, the daemon, it is best done in the setup-forgejo tests because they provide the context where forgejo is also setup and can be configured / reconfigured in various ways for test purposes.

The documentation you wrote is the guide I follow.

In this context, I think the simpler test is good enough as it demonstrates IPv6 is enabled. For the other part, the daemon, it is best done in the [setup-forgejo tests](https://code.forgejo.org/actions/setup-forgejo/pulls/107/files) because they provide the context where forgejo is also setup and can be configured / reconfigured in various ways for test purposes. The documentation you wrote is the guide I follow.
Author
Owner

For the record it is not possible to test external routing because there appears to be a bug in how IPv6 is supported in Debian LXC containers. For the purpose of verifying IPv6 is available in a workflow this is not strictly necessary although it would be a bonus.

For the record it is not possible to test external routing because [there appears to be a bug in how IPv6 is supported in Debian LXC containers](https://code.forgejo.org/forgejo/lxc-helpers/issues/19). For the purpose of verifying IPv6 is available in a workflow this is not strictly necessary although it would be a bonus.
earl-warren marked this conversation as resolved
earl-warren force-pushed wip-ipv6 from 226bf636e6 to 39e0d5b161 2023-12-03 13:56:38 +00:00 Compare
earl-warren added 1 commit 2023-12-03 14:13:26 +00:00
Some checks failed
/ example-docker-compose (pull_request) Failing after 9s
checks / build and test (pull_request) Successful in 1m4s
/ cascade (pull_request) Has been skipped
checks / runner exec tests (pull_request) Failing after 24s
569a8d5a2c
debug
earl-warren force-pushed wip-ipv6 from 569a8d5a2c to d7e471a392 2023-12-04 16:54:41 +00:00 Compare
earl-warren merged commit b96f044905 into main 2023-12-04 16:58:23 +00:00
earl-warren deleted branch wip-ipv6 2023-12-04 16:58:23 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#129
No description provided.