Add example to use buildkit and docker buildx #1413
No reviewers
Labels
No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
No milestone
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
forgejo/runner!1413
Loading…
Reference in a new issue
No description provided.
Delete branch "albundy83/runner:kubernetes-buildkit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -5,3 +5,3 @@NOTE: Docker in Docker (dind) requires elevated privileges on Kubernetes. The current way to achieve this is to set the pod `SecurityContext` to `privileged`. Keep in mind that this is a potential security issue that has the potential for a malicious application to break out of the container context.[`dind-docker.yaml`](dind-docker.yaml) creates a Deployment and Secret for Kubernetes to act as a runner. The Docker credentials are re-generated each time the pod connects and does not need to be persisted.[dind-docker.yaml](dind-docker.yaml) creates a Deployment and Secret for Kubernetes to act as a runner. The Docker credentials are re-generated each time the pod connects and does not need to be persisted.why?
Hello,
well, backquotes on a link are not very needed but if you think it's better, I can add them back :)
yes, please revert unrelated changes
@ -40,3 +46,1 @@registry: ${{ steps.add-vars.outputs.registry }}username: ${{ secrets.USERNAME_WRITE_REPOSITORY }}password: ${{ secrets.PASSWORD_WRITE_REPOSITORY }}run: |why?
I think as you have already docker in your hand, it's faster to login directly no ?
no. please avoid unrelated changes
7bab6e04ce0ba7ae6851Hello,
Is there any issue with this pull request ? @viceice ?
I think it make more sense to finish the official runner chart.
forgejo-helm/forgejo-runner#1
@viceice wrote in #1413 (comment):
Finish .. you mean start :)
@albundy83 wrote in #1413 (comment):
Anyway, I guess the example is still correct and it could be a start example for the runner chart, what do you think ?
@albundy83 wrote in #1413 (comment):
there is some start: forgejo-helm/forgejo-runner#2
6b75cc2e579aeb2923da4073fa2067da9e35cdf3Hello,
will you merge this example and doc ?
@viceice Could you have another look? It doesn't make sense that I review it because I know next to nothing about this topic.
@aahlenst wrote in #1413 (comment):
it still doesn't make sense to me to add this here. users should use the helm chart.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.