chore: remove ability to use secrets for registry authentication #1610

Merged
mfenniak merged 1 commit from aahlenst/runner:remove-secrets-registry-auth into main 2026-07-10 02:18:33 +00:00
Member

When the secrets DOCKER_USERNAME and DOCKER_PASSWORD were defined in Forgejo, Forgejo Runner would attempt to use them to authenticate to any container registry that required authentication when pulling images. The functionality can be replaced by specifying credentials explicitly using jobs.<job_id>.container.credentials.

See #1319.

  • other
    • PR: chore: remove ability to use secrets for registry authentication
When the secrets `DOCKER_USERNAME` and `DOCKER_PASSWORD` were defined in Forgejo, Forgejo Runner would attempt to use them to authenticate to _any_ container registry that required authentication when pulling images. The functionality can be replaced by specifying credentials explicitly using [`jobs.<job_id>.container.credentials`](https://forgejo.org/docs/latest/user/actions/reference/#jobsjob_idcontainercredentials). See https://code.forgejo.org/forgejo/runner/issues/1319. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1610): <!--number 1610 --><!--line 0 --><!--description Y2hvcmU6IHJlbW92ZSBhYmlsaXR5IHRvIHVzZSBzZWNyZXRzIGZvciByZWdpc3RyeSBhdXRoZW50aWNhdGlvbg==-->chore: remove ability to use secrets for registry authentication<!--description--> <!--end release-notes-assistant-->
chore: remove ability to use secrets for registry authentication
All checks were successful
cascade / debug (pull_request_target) Has been skipped
test-multi-platform / Build Forgejo Runner (pull_request) Has been skipped
test-multi-platform / Build unsupported platforms (pull_request) Has been skipped
test-multi-platform / runner exec tests (pull_request) Has been skipped
test-multi-platform / Run integration tests with Docker (docker-latest) (pull_request) Has been skipped
test-multi-platform / Run integration tests with Docker (docker-stable) (pull_request) Has been skipped
test-multi-platform / Run integration tests with Podman (pull_request) Has been skipped
test-multi-platform / validate mocks (pull_request) Has been skipped
test-multi-platform / validate pre-commit-hooks file (pull_request) Has been skipped
issue-labels / release-notes (pull_request_target) Successful in 7s
checks / validate mocks (pull_request) Successful in 45s
checks / validate pre-commit-hooks file (pull_request) Successful in 54s
checks / Build Forgejo Runner (pull_request) Successful in 1m7s
checks / runner exec tests (pull_request) Successful in 41s
checks / Build unsupported platforms (pull_request) Successful in 1m45s
checks / Run integration tests with Docker (docker-latest) (pull_request) Successful in 13m0s
checks / Run integration tests with Podman (pull_request) Successful in 15m1s
checks / Run integration tests with Docker (docker-stable) (pull_request) Successful in 14m51s
test-multi-platform / arm64 (pull_request) Has been skipped
cascade / end-to-end (pull_request_target) Successful in 5s
cascade / forgejo (pull_request_target) Successful in 1m34s
e82ac3ef9e
mfenniak approved these changes 2026-07-10 02:18:27 +00:00
mfenniak referenced this pull request from a commit 2026-08-24 21:22:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1610
No description provided.