chore: remove Gitea compatibility #1611
No reviewers
Labels
No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
run-multi-platform-tests
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
forgejo/runner!1611
Loading…
Reference in a new issue
No description provided.
Delete branch "aahlenst/runner:remove-gitea-compat-layer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since the introduction of workflow validation, Forgejo Runner would refuse running workflows that reference the
giteacontext. This change removes the remains of the Gitea support: thegiteacontext and some supporting variables likeGITEA_TOKEN.See https://codeberg.org/forgejo/discussions/issues/439 and #1319.
@ -258,3 +255,3 @@taskContext := task.Context.FieldsdefaultActionURL := client.BackwardCompatibleContext(task, "default_actions_url")defaultActionURL := taskContext["forgejo_default_actions_url"].GetStringValue()Should I revert that due to https://codeberg.org/forgejo/forgejo/pulls/13406, @mfenniak?
Yeah, I think so. Otherwise the v13 release will need to wait until the next patch releases of Forgejo, and then only be supported on the latest releases -- that will be inconvenient for everyone.
Good catch for finding this problem. 👍