chore: remove workflow command add-path #1616

Merged

mfenniak merged 1 commit from aahlenst/runner:remove-add-path into main 2026-07-15 01:09:19 +00:00

Conversation 8 Commits 1 Files changed 3 +2 -31

aahlenst commented 2026-07-10 20:19:10 +00:00

Member

• Copy link
• Copy Markdown

The workflow command add-path allows amending PATH that is injected into successive steps. Unfortunately, it is difficult to use securely. Therefore, it is removed from Forgejo Runner. If workflows still use add-path, a warning will be printed. Contrary to GitHub Actions, it is not possible to restore it again by setting the environment variable ACTIONS_ALLOW_UNSECURE_COMMANDS=true because better alternatives exist. Workflows that need to amend PATH of successive steps should write to $FORGEJO_PATH:

on:
  push:
jobs:
  test:
    runs-on: debian
    steps:
      - run: |
          echo "/add-to-path" > "$FORGEJO_PATH"
      - run: |
          echo "$PATH"

See #1455 and GitHub Actions: Deprecating set-env and add-path commands.

• other
  • PR: chore: remove workflow command add-path

The workflow command `add-path` allows amending `PATH` that is injected into successive steps. Unfortunately, it is difficult to use securely. Therefore, it is removed from Forgejo Runner. If workflows still use `add-path`, a warning will be printed. Contrary to GitHub Actions, it is not possible to restore it again by setting the environment variable `ACTIONS_ALLOW_UNSECURE_COMMANDS=true` because better alternatives exist. Workflows that need to amend `PATH` of successive steps should write to `$FORGEJO_PATH`: ```yaml on: push: jobs: test: runs-on: debian steps: - run: | echo "/add-to-path" > "$FORGEJO_PATH" - run: | echo "$PATH" ``` See https://code.forgejo.org/forgejo/runner/issues/1455 and [GitHub Actions: Deprecating set-env and add-path commands](https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/#patching-your-actions-and-workflows). <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1616): <!--number 1616 --><!--line 0 --><!--description Y2hvcmU6IHJlbW92ZSB3b3JrZmxvdyBjb21tYW5kIGFkZC1wYXRo-->chore: remove workflow command add-path<!--description--> <!--end release-notes-assistant-->

aahlenst added the

Kind/Breaking

Kind/Chore

labels 2026-07-10 20:19:10 +00:00

aahlenst commented 2026-07-10 20:22:27 +00:00

Author

Member

• Copy link
• Copy Markdown

This function

act/runner/command.go

Lines 129 to 138 in 04be7a7

	func (rc *RunContext) addPath(ctx context.Context, arg string) {
	common.Logger(ctx).WithFields(logrus.Fields{"command": "add-path", "arg": arg}).Infof(" \U00002699 ::add-path:: %s", arg)
	extraPath := []string{arg}
	for _, v := range rc.ExtraPath {
	if v != arg {
	extraPath = append(extraPath, v)
	}
	}
	rc.ExtraPath = extraPath
	}

is still needed. However, I'm a bit unsure what to do about the log message

common.Logger(ctx).WithFields(logrus.Fields{"command": "add-path", "arg": arg}).Infof("  \U00002699  ::add-path:: %s", arg)

because it still refers to the command add-path.

This function https://code.forgejo.org/forgejo/runner/src/commit/04be7a7956798fe87d4c786775c0a3ffb8456b2d/act/runner/command.go#L129-L138 is still needed. However, I'm a bit unsure what to do about the log message ``` common.Logger(ctx).WithFields(logrus.Fields{"command": "add-path", "arg": arg}).Infof(" \U00002699 ::add-path:: %s", arg) ``` because it still refers to the command `add-path`.

aahlenst added the

run-end-to-end-tests

label 2026-07-11 14:01:17 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2026-07-11 14:01:27 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1616/head to forgejo/runner-1616 #1039

cascading-pr commented 2026-07-11 14:01:28 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1039

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1039

mfenniak commented 2026-07-12 01:22:43 +00:00

Owner

• Copy link
• Copy Markdown

@aahlenst wrote in #1616 (comment):

However, I'm a bit unsure what to do about the log message...

The first concern with logging in runner is always, "is it really logging, or does it do something functional"? Surely it can't be functional here because that would be causing an infinite loop in the command handler, so pretty confident that isn't the case.

Maybe just change it to indicate %q was added to PATH?

@aahlenst wrote in https://code.forgejo.org/forgejo/runner/pulls/1616#issuecomment-94213: > However, I'm a bit unsure what to do about the log message... The first concern with logging in runner is always, "is it really logging, or does it do something functional"? Surely it can't be functional here because that would be causing an infinite loop in the command handler, so pretty confident that isn't the case. Maybe just change it to indicate `%q was added to PATH`?

aahlenst force-pushed remove-add-path from 806290f037 to 85088b4ba6 2026-07-12 12:03:32 +00:00 Compare

cascading-pr commented 2026-07-12 12:03:42 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1039

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1039

aahlenst force-pushed remove-add-path from 85088b4ba6 to 686b364275 2026-07-12 12:05:20 +00:00 Compare

aahlenst commented 2026-07-12 12:05:48 +00:00

Author

Member

• Copy link
• Copy Markdown

@mfenniak wrote in #1616 (comment):

Maybe just change it to indicate %q was added to PATH?

Thanks! Done.

@mfenniak wrote in https://code.forgejo.org/forgejo/runner/pulls/1616#issuecomment-94308: > Maybe just change it to indicate `%q was added to PATH`? Thanks! Done.

cascading-pr commented 2026-07-12 12:08:40 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1039

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1039

aahlenst force-pushed remove-add-path from 686b364275 to a3df21030c 2026-07-13 20:40:35 +00:00 Compare

cascading-pr commented 2026-07-13 20:40:45 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1039

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1039

mfenniak approved these changes 2026-07-15 01:08:39 +00:00

mfenniak merged commit befeb7f2ef into main 2026-07-15 01:09:19 +00:00

mfenniak referenced this pull request from a commit 2026-07-15 01:09:20 +00:00

chore: remove workflow command add-path (#1616)

mfenniak referenced this pull request 2026-07-15 01:11:35 +00:00

Deprecation Cleanup for Major Release v13 #1319

viceice-bot referenced this pull request 2026-08-24 20:45:37 +00:00

Update forgejo-runner to v13 #1706

mfenniak referenced this pull request from a commit 2026-08-24 21:22:44 +00:00

Update forgejo-runner to v13 (#1706)

viceice-bot referenced this pull request from actions/setup-forgejo 2026-09-01 00:21:18 +00:00

Update dependency forgejo/runner to v13 #1107

mfenniak referenced this pull request from a commit 2026-09-01 01:51:26 +00:00

Update dependency forgejo/runner to v13 (#1107)

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

forgejo/runner!1616

No description provided.