fix: fail jobs, steps if expression interpolation fails #1646

Merged

mfenniak merged 11 commits from aahlenst/runner:expression-error into main 2026-07-25 20:02:25 +00:00

Conversation 6 Commits 11 Files changed 21 +783 -256

aahlenst commented 2026-07-23 20:33:12 +00:00

Member

• Copy link
• Copy Markdown

Forgejo Runner supports expressions in workflows, for example, format('Hello {0} {1} {2}', 'Mona', 'the', 'Octocat'). If Forgejo Runner encounters an invalid expression, it logs an error, but otherwise progresses as if nothing had happened. That can cause unpredictable or even unwanted results. This change turns invalid expressions into a hard error that stops normal execution and fails the respective step.

Resolves #1596.

• bug fixes
  • PR: fix: fail jobs, steps if expression interpolation fails

Forgejo Runner supports expressions in workflows, for example, `format('Hello {0} {1} {2}', 'Mona', 'the', 'Octocat')`. If Forgejo Runner encounters an invalid expression, it logs an error, but otherwise progresses as if nothing had happened. That can cause unpredictable or even unwanted results. This change turns invalid expressions into a hard error that stops normal execution and fails the respective step. Resolves https://code.forgejo.org/forgejo/runner/issues/1596. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1646): <!--number 1646 --><!--line 0 --><!--description Zml4OiBmYWlsIGpvYnMsIHN0ZXBzIGlmIGV4cHJlc3Npb24gaW50ZXJwb2xhdGlvbiBmYWlscw==-->fix: fail jobs, steps if expression interpolation fails<!--description--> <!--end release-notes-assistant-->

aahlenst added the

Kind/Breaking

label 2026-07-23 20:33:12 +00:00

aahlenst added the

Kind/Bug

run-end-to-end-tests

labels 2026-07-23 20:33:43 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2026-07-23 20:34:10 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1646/head to forgejo/runner-1646 #1058

cascading-pr commented 2026-07-23 20:34:10 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1058

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1058

aahlenst force-pushed expression-error from e4fb563cec to 46f6e5ca31 2026-07-23 20:35:53 +00:00 Compare

cascading-pr commented 2026-07-23 20:40:53 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1058

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1058

aahlenst force-pushed expression-error from 46f6e5ca31 to b776bbd5e7 2026-07-24 11:58:36 +00:00 Compare

cascading-pr commented 2026-07-24 11:58:46 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1058

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1058

aahlenst force-pushed expression-error from b776bbd5e7 to f77f54dd1a 2026-07-24 18:56:55 +00:00 Compare

cascading-pr commented 2026-07-24 18:57:08 +00:00

Contributor

• Copy link
• Copy Markdown

cascading-pr updated at actions/setup-forgejo#1058

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1058

aahlenst changed title from WIP: fix: fail jobs, steps if expression interpolation fails to fix: fail jobs, steps if expression interpolation fails 2026-07-24 19:04:19 +00:00

mfenniak approved these changes 2026-07-25 20:02:07 +00:00

mfenniak left a comment

• Copy link
• Copy Markdown

Painful work! But it looks great to me, and very thoughtful work in specific areas like secret management.

I've run this development branch against a few test systems and have not encountered any problems. Plus end-to-end tests without any failure, and very few test changes required here... it seems to build a lot of confidence that it's going to be generally low impact. 👍

Thank you!

Painful work! But it looks great to me, and very thoughtful work in specific areas like secret management. I've run this development branch against a few test systems and have not encountered any problems. Plus end-to-end tests without any failure, and very few test changes required here... it seems to build a lot of confidence that it's going to be generally low impact. 👍 Thank you!

🎉 1

mfenniak merged commit e077c395bc into main 2026-07-25 20:02:25 +00:00

mfenniak referenced this pull request from a commit 2026-07-25 20:02:26 +00:00

fix: fail jobs, steps if expression interpolation fails (#1646)

aahlenst commented 2026-07-25 20:39:27 +00:00

Author

Member

• Copy link
• Copy Markdown

Thanks a lot for performing additional tests!

Thanks a lot for performing additional tests!

aahlenst referenced this pull request 2026-07-26 10:22:12 +00:00

fix: turn invalid matrices into a hard error #1654

mfenniak referenced this pull request from a commit 2026-07-27 19:24:08 +00:00

fix: turn invalid matrices into a hard error (#1654)

viceice-bot referenced this pull request 2026-08-24 20:45:37 +00:00

Update forgejo-runner to v13 #1706

mfenniak referenced this pull request from a commit 2026-08-24 21:22:44 +00:00

Update forgejo-runner to v13 (#1706)

viceice-bot referenced this pull request from actions/setup-forgejo 2026-09-01 00:21:18 +00:00

Update dependency forgejo/runner to v13 #1107

mfenniak referenced this pull request from a commit 2026-09-01 01:51:26 +00:00

Update dependency forgejo/runner to v13 (#1107)

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

  

run-multi-platform-tests

Label a PR for automatic execution of test suite on arm64 architecture.

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

run-multi-platform-tests

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

forgejo/runner!1646

No description provided.