fix: turn invalid matrices into a hard error #1654

Merged
mfenniak merged 1 commit from aahlenst/runner:matrix-errors into main 2026-07-27 19:24:07 +00:00
Member

Invalid matrices, including invalid exclude keys, would only be logged, but the job would continue and potentially "succeed".

This change should not impact users of Forgejo, because most problems are caught by workflow validation before the workflows are dispatched to Forgejo Runner.

Follow-up to #1646.

  • bug fixes
    • PR: fix: turn invalid matrices into a hard error
Invalid matrices, including invalid exclude keys, would only be logged, but the job would continue and potentially "succeed". This change should not impact users of Forgejo, because most problems are caught by workflow validation before the workflows are dispatched to Forgejo Runner. Follow-up to https://code.forgejo.org/forgejo/runner/pulls/1646. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1654): <!--number 1654 --><!--line 0 --><!--description Zml4OiB0dXJuIGludmFsaWQgbWF0cmljZXMgaW50byBhIGhhcmQgZXJyb3I=-->fix: turn invalid matrices into a hard error<!--description--> <!--end release-notes-assistant-->
fix: turn invalid matrices into a hard error
All checks were successful
cascade / debug (pull_request_target) Has been skipped
test-multi-platform / Build Forgejo Runner (pull_request) Has been skipped
test-multi-platform / Build unsupported platforms (pull_request) Has been skipped
test-multi-platform / Run exec tests with Docker (docker-latest) (pull_request) Has been skipped
test-multi-platform / Run integration tests with Docker (docker-latest) (pull_request) Has been skipped
test-multi-platform / Run integration tests with Docker (docker-stable) (pull_request) Has been skipped
test-multi-platform / Run integration tests with Podman (pull_request) Has been skipped
test-multi-platform / validate mocks (pull_request) Has been skipped
test-multi-platform / validate pre-commit-hooks file (pull_request) Has been skipped
checks / validate mocks (pull_request) Successful in 26s
checks / Build Forgejo Runner (pull_request) Successful in 29s
checks / validate pre-commit-hooks file (pull_request) Successful in 31s
checks / Run exec tests with Docker (docker-latest) (pull_request) Successful in 26s
checks / Build unsupported platforms (pull_request) Successful in 55s
checks / Run integration tests with Docker (docker-latest) (pull_request) Successful in 10m7s
checks / Run integration tests with Podman (pull_request) Successful in 10m45s
checks / Run integration tests with Docker (docker-stable) (pull_request) Successful in 11m21s
issue-labels / release-notes (pull_request_target) Successful in 3s
test-multi-platform / arm64 (pull_request) Has been skipped
cascade / end-to-end (pull_request_target) Successful in 6s
cascade / forgejo (pull_request_target) Successful in 37s
4bf2b0a7b3
Contributor

cascading-pr updated at actions/setup-forgejo#1066

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/1066
mfenniak approved these changes 2026-07-27 19:23:58 +00:00
mfenniak left a comment

Looks good to me. 👍

Looks good to me. 👍
mfenniak referenced this pull request from a commit 2026-08-24 21:22:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
forgejo/runner!1654
No description provided.