add combined labels back to registry #176

Merged
earl-warren merged 5 commits from thefox/runner:label_loading_patch into main 2024-04-10 22:47:37 +00:00
Member

potential fix for #174

potential fix for #174
thefox added 1 commit 2024-04-07 09:39:21 +00:00
after reading labels, load them into registration
All checks were successful
/ cascade (pull_request) Has been skipped
checks / build and test (pull_request) Successful in 57s
checks / runner exec tests (pull_request) Successful in 52s
/ example-docker-compose (pull_request) Successful in 2m21s
abc9bf653a
earl-warren added the
Kind/Bug
label 2024-04-09 10:35:08 +00:00
thefox added 1 commit 2024-04-09 18:53:36 +00:00
add label change post runner creation
All checks were successful
/ cascade (pull_request) Has been skipped
checks / build and test (pull_request) Successful in 54s
checks / runner exec tests (pull_request) Successful in 47s
/ example-docker-compose (pull_request) Successful in 2m30s
ac7d0ce703
thefox added 1 commit 2024-04-10 20:40:09 +00:00
added simple test to label update
Some checks failed
/ cascade (pull_request) Has been skipped
checks / build and test (pull_request) Failing after 1m0s
checks / runner exec tests (pull_request) Has been skipped
/ example-docker-compose (pull_request) Successful in 2m6s
67fe3f7d4a
Author
Member

@earl-warren I've added a test to this. Took a while because I wanted to check daemon rather than runner but this is better than nothing. We can go with this for now unless you have idea how to check the actual daemon function for this.

@earl-warren I've added a test to this. Took a while because I wanted to check daemon rather than runner but this is better than nothing. We can go with this for now unless you have idea how to check the actual daemon function for this.
earl-warren reviewed 2024-04-10 21:01:20 +00:00
@ -0,0 +13,4 @@
ls := labels.Labels{}
initialLabel, err := labels.Parse("testlabel:docker://alpine")
assert.Nil(t, err)
Owner

NoError is more idiomatic than Nil

`NoError` is more idiomatic than `Nil`
thefox marked this conversation as resolved
thefox added 1 commit 2024-04-10 21:21:50 +00:00
replace Nil with NoError
All checks were successful
/ cascade (pull_request) Has been skipped
checks / build and test (pull_request) Successful in 1m2s
checks / runner exec tests (pull_request) Successful in 48s
/ example-docker-compose (pull_request) Successful in 2m30s
af1fe86440
earl-warren requested changes 2024-04-10 21:43:59 +00:00
Dismissed
earl-warren left a comment
Owner

An addition to the release notes and good to merge.

An addition to the release notes and good to merge.
thefox force-pushed label_loading_patch from af1fe86440 to bcfea8f688 2024-04-10 21:52:36 +00:00 Compare
thefox force-pushed label_loading_patch from bcfea8f688 to 5539ef7275 2024-04-10 21:56:03 +00:00 Compare
thefox requested review from earl-warren 2024-04-10 22:03:44 +00:00
earl-warren approved these changes 2024-04-10 22:10:14 +00:00
earl-warren merged commit 5e51d8ed42 into main 2024-04-10 22:47:37 +00:00
earl-warren deleted branch label_loading_patch 2024-04-10 22:47:37 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#176
No description provided.