forgejo/runner
12
29
Fork 21
Code Issues 38 Pull requests 1 Actions Packages Releases 26 Activity

workaround: docker-compose example not using the specified labels (step 2) #177

Merged
earl-warren merged 7 commits from earl-warren/runner:wip-upgrade-example into main 2024-04-07 18:52:42 +00:00
Conversation 1 Commits 7 Files changed 4 +39 -25
earl-warren commented 2024-04-07 10:36:20 +00:00
Owner
Copy link

Builds on top of #175 which, among other things, implements a workaround by explicitly setting the labels in both .runner & config.yml.

  • force the labels in the .runner file as a workaround for #174
  • do not use depends_on because its behavior is difficult to understand and sometime races
  • improve the documentation

Refs: #174

Builds on top of https://code.forgejo.org/forgejo/runner/pulls/175 which, among other things, implements a workaround by explicitly setting the labels in both .runner & config.yml. * force the labels in the .runner file as a workaround for #174 * do not use `depends_on` because its behavior is difficult to understand and sometime races * improve the documentation Refs: https://code.forgejo.org/forgejo/runner/issues/174
earl-warren added the
Kind/Bug
Kind/Documentation
 labels 2024-04-07 10:36:20 +00:00
earl-warren added 1 commit 2024-04-07 10:36:20 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Successful in 43s
Details
checks / runner exec tests (pull_request) Successful in 36s
Details
/ example-docker-compose (pull_request) Failing after 5m36s
Details
159277af9e
fix: the docker-compose example is racy 
When the labels in .runner & config.yml are different, the .runner
labels take precedence and then the labels found in config.yml are
written to .runner. In the docker compose example the .runner file has
no labels the first time around, hence defaults to bullseye. So the
second time around the labels from config.yml will be used.

Workaround this bug until it is fixed by running the daemon right
after the registration for the sake of updating the .runner file.

The `compose-demo-workflow.yml` has

```yaml
    depends_on:
      runner-register:
        condition: service_completed_successfully
```

which does not block in the way one would expect. Replace that with
assertion on files.
earl-warren self-assigned this 2024-04-07 10:36:26 +00:00
earl-warren force-pushed wip-upgrade-example from 159277af9e to 0f6be9f253 2024-04-07 11:01:09 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 0f6be9f253 to 6181438eec 2024-04-07 11:03:21 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 6181438eec to 260e1370ca 2024-04-07 11:28:27 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 260e1370ca to 2bb7667643 2024-04-07 14:16:38 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 2bb7667643 to e12df8d551 2024-04-07 14:23:35 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from e12df8d551 to 0db35cd1b0 2024-04-07 14:27:41 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 0db35cd1b0 to 063838e8dd 2024-04-07 14:34:39 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 063838e8dd to ee4a886ca8 2024-04-07 14:43:20 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from ee4a886ca8 to e28f20bbd0 2024-04-07 15:06:23 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from e28f20bbd0 to 3da669eb90 2024-04-07 15:16:03 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from 3da669eb90 to a4dbe64e89 2024-04-07 15:21:16 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from a4dbe64e89 to a4f129d128 2024-04-07 15:26:03 +00:00 Compare
earl-warren force-pushed wip-upgrade-example from a4f129d128 to 868555f349 2024-04-07 15:37:35 +00:00 Compare
earl-warren changed title from fix: the docker-compose example is racy to workaround: docker-compose example not using the specified labels 2024-04-07 15:40:33 +00:00
earl-warren requested review from thefox 2024-04-07 15:42:53 +00:00
earl-warren commented 2024-04-07 15:44:38 +00:00
Author
Owner
Copy link

@zwanto this is not yet the fix but it makes the example function in a predictable way.

@zwanto this is not yet the fix but it makes the example function in a predictable way.
thefox approved these changes 2024-04-07 15:45:25 +00:00
earl-warren force-pushed wip-upgrade-example from 868555f349 to 4c05530aa3 2024-04-07 18:35:33 +00:00 Compare
earl-warren changed title from workaround: docker-compose example not using the specified labels to workaround: docker-compose example not using the specified labels (step 2) 2024-04-07 18:37:20 +00:00
earl-warren added 1 commit 2024-04-07 18:48:40 +00:00
All checks were successful
checks / build and test (pull_request) Successful in 39s
Details
checks / runner exec tests (pull_request) Successful in 36s
Details
/ example-docker-compose (pull_request) Successful in 3m29s
Details
/ cascade (pull_request) Has been skipped
Details
0348074eee
docker-compose example: use node:20-bookworm instead of the default
earl-warren merged commit 8a2d4cb7cb into main 2024-04-07 18:52:42 +00:00
earl-warren deleted branch wip-upgrade-example 2024-04-07 18:52:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
thefox
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#177
No description provided.
Delete branch "earl-warren/runner:wip-upgrade-example"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?