fix name of binary to `forgejo-runner` for rootless docker image

louis9902 commented

2023-07-08 09:49:04 +00:00

Contributor

While testing, I noticed that the rootless image can not be build because of errors while building the docker image. The errors are coming from the renamed binary, which is not found during the container build.

louis9902 added 1 commit 2023-07-08 09:49:05 +00:00

checks / check and test (pull_request) Successful in 1m2s

Details

8fa9c5df20

fix name of binary to forgejo-runner for rootless docker image

earl-warren commented

2023-07-08 10:01:03 +00:00

Owner

It would be nice to publish the rootless image at https://code.forgejo.org/forgejo/-/packages/container/runner/versions. The focus has been on produce the binaries for now. And the container images are primarily a vessel to compile them. But in a k8s context there is a need for rootless images, AFAIU. Is this your target?

earl-warren merged commit cfb20e8131 into main

2023-07-08 10:02:03 +00:00

earl-warren referenced this pull request from a commit

2023-07-08 10:02:03 +00:00

Merge pull request 'fix name of binary to `forgejo-runner` for rootless docker image' (#43) from louis9902/runner:fix_rootless_script_bin_name into main

louis9902 commented

2023-07-08 11:36:45 +00:00

Author

Contributor

No, not really, I'm just trying to get the runner running as rootless container (using podman with a rootless user and root inside the container), but so far without success.

earl-warren commented

2023-07-08 11:53:32 +00:00

Owner

I think it would be a simpler if https://codeberg.org/forgejo/forgejo/issues/983 was implemented. You're trying with docker compose or something different? I'm deploying binaries myself but I see the appeal for running from within a container.

earl-warren commented

2023-07-08 11:54:22 +00:00

Owner

By docker compose I mean whatever is equivalent to that with podman.

By `docker compose` I mean whatever is equivalent to that with podman.

louis9902 commented

2023-07-08 14:10:43 +00:00

Author

Contributor

I'm currently using ansible and podman quadlet (systemd unit generator). I deploy the *.kube file and the corresponding kube.yml file with ansible create a systemd unit and start and enable the created unit. So I can get auto restart if my server restarts as well as auto updating if I enable the podman service.
And if the forgejo subcommand is coming this will make a lot of things a lot easier in terms of deployment.

I'm currently using ansible and podman quadlet (systemd unit generator). I deploy the *.kube file and the corresponding kube.yml file with ansible create a systemd unit and start and enable the created unit. So I can get auto restart if my server restarts as well as auto updating if I enable the podman service. And if the forgejo subcommand is coming this will make a lot of things a lot easier in terms of deployment.

earl-warren commented

2023-07-08 14:38:00 +00:00

Owner

And if the forgejo subcommand is coming this will make a lot of things a lot easier in terms of deployment.

I'll work on that tomorrow.

> And if the forgejo subcommand is coming this will make a lot of things a lot easier in terms of deployment. I'll work on that tomorrow.

fix name of binary to forgejo-runner for rootless docker image #43

fix name of binary to `forgejo-runner` for rootless docker image #43