forgejo/runner
12
29
Fork 21
Code Issues 39 Pull requests 1 Actions Packages Releases 26 Activity

WIP: reconcile commits from all sources #71

Closed
earl-warren wants to merge 2 commits from earl-warren/runner:wip-act into main
pull from: earl-warren/runner:wip-act
merge into: forgejo:main
Conversation 2 Commits 2 Files changed 3 +12 -11
earl-warren commented 2023-08-23 12:55:49 +00:00
Owner
Copy link

Reconcile commits from the following sources:

Reconcile commits from the following sources: * the main branch of this repository * https://gitea.com/gitea/act_runner as of ed35b09b8f4a0fa0a280981bd8b5991cb4bb8613
earl-warren added the
Kind/Enhancement
 label 2023-08-23 12:55:49 +00:00
earl-warren added 32 commits 2023-08-23 12:55:52 +00:00
87058716fb fix(register): refactor context usage in registration functions (#286) 
- Add context parameter to `registerNoInteractive`, `registerInteractive`, and `doRegister` functions
- Remove the creation of a new context in `doRegister`, now using the passed context instead

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/286
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-committed-by: Bo-Yi Wu <appleboy.tw@gmail.com>
cf92a979e2 refactor(register): refactor registration functions and improve logging (#288) 
- Remove the else clause in the `registerInteractive` function, and unconditionally log "Runner registered successfully."
- Change the return value in the `doRegister` function from `nil` to `ctx.Err()`.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/288
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-committed-by: Bo-Yi Wu <appleboy.tw@gmail.com>
db662b3690 ci(lint): refactor code for clarity and linting compliance (#289) 
- Removed `deadcode`, `structcheck`, and `varcheck` linters from `.golangci.yml`
- Fixed a typo in a comment in `daemon.go`
- Renamed `defaultActionsUrl` to `defaultActionsURL` in `exec.go`
- Removed unnecessary else clause in `exec.go` and `runner.go`
- Simplified variable initialization in `exec.go`
- Changed function name from `getHttpClient` to `getHTTPClient` in `http.go`
- Removed unnecessary else clause in `labels_test.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/289
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-committed-by: Bo-Yi Wu <appleboy.tw@gmail.com>
73adae040d Upgrade act (#291) 
Follow https://gitea.com/gitea/act/pulls/74
Fix #277, #290

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/291
Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-committed-by: Zettat123 <zettat123@gmail.com>
dcf84d8a53 Avoid https://github.com/nektos/act/issues/1908 by specifying golang 1.20.5. (#295) 
Without this, actions fail when attempting to clone the repo:

```
2023-07-18 17:11:02 [Smoke Test/Run basic test suite] failed to attach to exec: http: invalid Host header
```

This appears to be the same as https://github.com/nektos/act/issues/1908, and only shows up with golang 1.20.6.  Staying with golang 1.20.5 is a temporary solution to avoid the bug until it is fixed upstream.

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/295
Co-authored-by: Thomas E Lackey <telackey@bozemanpass.com>
Co-committed-by: Thomas E Lackey <telackey@bozemanpass.com>
1a7ec5f339 Upgrade gitea/act (#298) 
Follow  https://gitea.com/gitea/act/pulls/75

Co-authored-by: Jason Song <i@wolfogre.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/298
Co-authored-by: sillyguodong <gedong_1994@163.com>
Co-committed-by: sillyguodong <gedong_1994@163.com>
a1bb3b56fd Catch the panic and print the error (#305) 
refactor # 215  Catch the panic and print the error
close #215

Co-authored-by: CaiCandong <1290147055@qq.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/305
Co-authored-by: caicandong <caicandong@noreply.gitea.com>
Co-committed-by: caicandong <caicandong@noreply.gitea.com>
8f88e4f15a Update README.md (#302) 
Correct Quick Start section.

Co-authored-by: Jason Song <i@wolfogre.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/302
Co-authored-by: Konstantin Podsvirov <podsvirov@noreply.gitea.com>
Co-committed-by: Konstantin Podsvirov <podsvirov@noreply.gitea.com>
49a2fcc138 fix endless loop (#306) 
fix endless loop in  poll
relate #305

Co-authored-by: CaiCandong <1290147055@qq.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/306
Co-authored-by: caicandong <caicandong@noreply.gitea.com>
Co-committed-by: caicandong <caicandong@noreply.gitea.com>
12999b61dd Reduce unnecessary DB queries for Actions tasks (#219) 
implement: https://github.com/go-gitea/gitea/issues/24544

Changes:
- Add a global variable `tasksVersion` to store the lastest version number which returned by Gitea.
- Pass `tasksVersion` to Gitea when invoking `FetchTask`.
- If there is no task in the `FetchTask` response, store the version from the `FetchTask` response into `tasksVersion` variable.
- If there is a task in the `FetchTask` response, set `tasksVersion` to zero to focre query db in next `FetchTask` request.

Related:
- Protocol: https://gitea.com/gitea/actions-proto-def/pulls/10
- Gitea side: https://github.com/go-gitea/gitea/pull/25199

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/219
Co-authored-by: sillyguodong <gedong_1994@163.com>
Co-committed-by: sillyguodong <gedong_1994@163.com>
9fc823e4b1 Fix "http: invalid Host header" issue (#319) 
This issue  is caused by the addition of validation logic for `Host` in `http.Request` in golang 1.20.6 (see https://go-review.googlesource.com/c/go/+/507357/6/src/net/http/request.go)

In `act`, when execute `ContainerExecAttach()`(see 22d91e3ac3/pkg/container/docker_run.go (L594)), the actual value of `request.Host` is `"/var/run/docker.sock"`. This does not conform to the specification described in `validhostHeader`.
 <details> <summary>ValidHostHeader()</summary>

![image](/attachments/57fb13ba-1c74-47f6-ac48-231a72a1947e)
</details>
So this PR follow upstream: https://github.com/nektos/act/pull/1917 and revert https://gitea.com/gitea/act_runner/pulls/295

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/319
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: sillyguodong <gedong_1994@163.com>
Co-committed-by: sillyguodong <gedong_1994@163.com>
82c3c2df1a Upgrade Go to 1.21 and bump other dependencies (#330) 
Co-authored-by: harryzcy <harry@harryzheng.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/330
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: harryzcy <harryzcy@noreply.gitea.com>
Co-committed-by: harryzcy <harryzcy@noreply.gitea.com>
7fc1b91ba6 Update to go1.21 in Dockerfile.rootless (#332) 
Follow #330

Fix https://gitea.com/gitea/act_runner/pulls/330#issuecomment-747099

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/332
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: appleboy <appleboy.tw@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
Co-committed-by: Jason Song <i@wolfogre.com>
03f0829d09 Add ForcePull option (#339) 
Close #271

What it does: instead of forcing the value of `ForcePull` to false, the user can now configure it on the runner yaml

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/339
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: Gianni Angelozzi <gianni@sistema3.it>
Co-committed-by: Gianni Angelozzi <gianni@sistema3.it>
ed35b09b8f change podman socket path (#341) 
port of https://github.com/nektos/act/pull/1961
closes gitea/act_runner#274

Reviewed-on: https://gitea.com/gitea/act_runner/pulls/341
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
86cabb95ad
[FORGEJO] README.md 
README documentation updates

reminder that the code is alpha quality & not secure
6d8d711430
[FORGEJO] release notes 
update release notes
86e50234d2
[FORGEJO] use alpine 3.18 
Refs: https://github.com/nektos/act/issues/1908

Bump Docker dependency

See forgejo/act#9 for more info.

Use forked act change branch

Bump version

Use forgejo fork v1.9.0

Revert #50

Now that #64 has been
merged we should be good to go.

Remove pinned go version in test workflow

Bump Go version to 1.21
All checks were successful
checks / check and test (pull_request) Successful in 1m3s
Details
5a23cdbb1c
REMOVE ME - ACT
earl-warren force-pushed wip-act from 5a23cdbb1c to a82cfc9e06 2023-08-23 13:28:34 +00:00 Compare
earl-warren force-pushed wip-act from a82cfc9e06 to d0031160bb 2023-08-23 13:28:49 +00:00 Compare
earl-warren force-pushed wip-act from d0031160bb to fea1615c07 2023-08-23 13:37:10 +00:00 Compare
dachary commented 2023-08-23 13:41:29 +00:00
Member
Copy link

The changes in this commit show that the docker container of the latest runner could not be used because it was missing tini (included in the build layer but not in the resulting image).

There needs to be some testing to verify the container image can actually run.

The changes in [this commit](https://code.forgejo.org/forgejo/runner/commit/2fb7a7958d0a1e0a9831ede34ee648f679124bf7) show that the docker container of the latest runner could not be used because it was missing `tini` (included in the build layer but not in the resulting image). There needs to be some testing to verify the container image can actually run.
earl-warren commented 2023-08-23 13:46:51 +00:00
Author
Owner
Copy link

The image was not useful or advertised to be usable before. And it turns out it is not more usable now. But since it is published, there is an implicit assumption it is supported. I'll work on docker based examples and tests in a followup PR.

The image was not useful or advertised to be usable before. And it turns out it is not more usable now. But since it is published, there is an implicit assumption it is supported. I'll work on docker based examples and tests in a followup PR.
dachary approved these changes 2023-08-23 13:49:16 +00:00
earl-warren force-pushed wip-act from fea1615c07 to f322b7d267 2023-08-23 14:08:50 +00:00 Compare
earl-warren closed this pull request 2023-08-23 15:40:45 +00:00
Some checks failed
checks / check and test (pull_request) Successful in 50s
Details
checks / check and test (push) Successful in 35s
Details
Integration tests for the release process / release-simulation (push) Failing after 3m55s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dachary
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#71
No description provided.
Delete branch "earl-warren/runner:wip-act"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?