forgejo/runner
12
29
Fork 21
Code Issues 38 Pull requests 1 Actions Packages Releases 26 Activity

refactor and simplify the release process #73

Merged
earl-warren merged 3 commits from wip-release-process into main 2023-08-25 13:44:45 +00:00
Conversation 0 Commits 3 Files changed 8 +185 -227
earl-warren commented 2023-08-25 13:23:54 +00:00
Owner
Copy link

The release process shares a lot with Forgejo. This removes most of the logic that is now shared between Forgejo and the runner and encapsulated in the https://code.forgejo.org/forgejo/forgejo-build-publish action.

Fixes: #26

The release process shares a lot with Forgejo. This removes most of the logic that is now shared between Forgejo and the runner and encapsulated in the https://code.forgejo.org/forgejo/forgejo-build-publish action. Fixes: https://code.forgejo.org/forgejo/runner/issues/26
earl-warren added the
Kind/Enhancement
 label 2023-08-25 13:23:54 +00:00
earl-warren added 3 commits 2023-08-25 13:23:58 +00:00
Some checks failed
checks / check and test (push) Successful in 46s
Details
Integration tests for the release process / release-simulation (push) Failing after 2m58s
Details
checks / check and test (pull_request) Successful in 38s
Details
d0d87b6864
debug release
earl-warren force-pushed wip-release-process from d0d87b6864 to bebe166be6 2023-08-25 13:25:42 +00:00 Compare
earl-warren force-pushed wip-release-process from bebe166be6 to c5f53958be 2023-08-25 13:32:24 +00:00 Compare
earl-warren requested review from dachary 2023-08-25 13:34:33 +00:00
dachary approved these changes 2023-08-25 13:44:04 +00:00
dachary left a comment
Member
Copy link

I would have expected more lines to be removed but that's a win in simplicity. And the replacement is more declarative than logic that requires testing. Overall it is a win.

I would have expected more lines to be removed but that's a win in simplicity. And the replacement is more declarative than logic that requires testing. Overall it is a win.
earl-warren merged commit e87b34bdc6 into main 2023-08-25 13:44:45 +00:00
earl-warren deleted branch wip-release-process 2023-08-25 13:44:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dachary
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#73
No description provided.
Delete branch "wip-release-process"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?