fix: enforce job.<job-id>.timeout-minutes #982

Merged

earl-warren merged 1 commit from earl-warren/runner:wip-timeout into main 2025-09-11 14:43:27 +00:00

Conversation 5 Commits 1 Files changed 6 +39 -6

earl-warren commented 2025-09-11 06:53:48 +00:00

Owner

Copy link

• enforce timeout-minutes timeout for jobs in a way similar to how it is done for steps
• minimal refactor of evaluateStepTimeout evaluateTimeout so it can be used by jobs as well, with additional debug information and error logging if parsing fails
• add integration tests for both step and job timeout-minutes, verifying expressions are allowed and evaluated

Resolves forgejo/runner#979

---

Manually verified to work as expected https://v13.next.forgejo.org/earl-warren/testtimeout-minutes/actions/runs/3/jobs/0/attempt/1

on: [push]
jobs:
  test:
    runs-on: docker
    timeout-minutes: 1
    steps:
      - run: |
          set -x
          while : ; do
            sleep 30
          done

• bug fixes
  • PR: fix: enforce job..timeout-minutes

- enforce timeout-minutes timeout for jobs in a way similar to how it is done for steps - minimal refactor of evaluateStepTimeout evaluateTimeout so it can be used by jobs as well, with additional debug information and error logging if parsing fails - add integration tests for both step and job timeout-minutes, verifying expressions are allowed and evaluated Resolves forgejo/runner#979 --- Manually verified to work as expected https://v13.next.forgejo.org/earl-warren/testtimeout-minutes/actions/runs/3/jobs/0/attempt/1 ```yaml on: [push] jobs: test: runs-on: docker timeout-minutes: 1 steps: - run: | set -x while : ; do sleep 30 done ```  <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/982): <!--number 982 --><!--line 0 --><!--description Zml4OiBlbmZvcmNlIGpvYi48am9iLWlkPi50aW1lb3V0LW1pbnV0ZXM=-->fix: enforce job.<job-id>.timeout-minutes<!--description--> <!--end release-notes-assistant-->

image.png

112 KiB

❤️ 1

earl-warren added the

Kind/Bug

label 2025-09-11 06:53:48 +00:00

earl-warren self-assigned this 2025-09-11 06:53:48 +00:00

earl-warren changed title from fix: enforce job.<id>.timeout-minutes to WIP: fix: enforce job.<id>.timeout-minutes 2025-09-11 06:53:54 +00:00

viceice approved these changes 2025-09-11 07:37:16 +00:00

Dismissed

earl-warren added the

run-end-to-end-tests

label 2025-09-11 08:24:36 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2025-09-11 08:24:54 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/982/head to forgejo/runner-982 #675

cascading-pr commented 2025-09-11 08:24:55 +00:00

Contributor

Copy link

cascading-pr updated at actions/setup-forgejo#675

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/675

earl-warren removed the

run-end-to-end-tests

label 2025-09-11 08:57:00 +00:00

earl-warren commented 2025-09-11 08:57:32 +00:00

Author

Owner

Copy link

@cascading-pr wrote in #982 (comment):

cascading-pr updated at actions/setup-forgejo#675

Pass. So ... this does not break anything obvious at least.

@cascading-pr wrote in https://code.forgejo.org/forgejo/runner/pulls/982#issuecomment-59610: > cascading-pr updated at actions/setup-forgejo#675 Pass. So ... this does not break anything obvious at least.

earl-warren force-pushed wip-timeout from 4d669faf78 to a100041dd4 2025-09-11 09:17:05 +00:00 Compare

earl-warren changed title from WIP: fix: enforce job.<id>.timeout-minutes to fix: enforce job.<id>.timeout-minutes 2025-09-11 09:24:29 +00:00

earl-warren requested review from mfenniak 2025-09-11 09:24:35 +00:00

viceice approved these changes 2025-09-11 09:27:36 +00:00

earl-warren changed title from fix: enforce job.<id>.timeout-minutes to fix: enforce job.<job-id>.timeout-minutes 2025-09-11 09:43:49 +00:00

mfenniak approved these changes 2025-09-11 14:08:18 +00:00

earl-warren merged commit 02a51c0a21 into main 2025-09-11 14:43:27 +00:00

earl-warren deleted branch wip-timeout 2025-09-11 14:43:27 +00:00

earl-warren referenced this pull request from a commit 2025-09-11 14:43:28 +00:00

fix: enforce job.<job-id>.timeout-minutes (#982)

viceice-bot referenced this pull request 2025-09-19 00:01:41 +00:00

Update forgejo-runner to v11.1.1 #1018

viceice-bot referenced this pull request from actions/setup-forgejo 2025-09-19 00:02:57 +00:00

Update dependency forgejo/runner to v11.1.1 #686

earl-warren referenced this pull request from a commit 2025-09-19 04:31:16 +00:00

Update forgejo-runner to v11.1.1 (#1018)

earl-warren referenced this pull request from a commit 2025-09-19 04:34:00 +00:00

Update dependency forgejo/runner to v11.1.1 (#686)

forgejo-mirror referenced this pull request from a commit 2025-09-19 05:01:26 +00:00

Update module code.forgejo.org/forgejo/runner/v11 to v11.1.1 (forgejo) (#9354)

Sign in to join this conversation.

Reviewers

No reviewers

viceice

mfenniak

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

earl-warren

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!982

No description provided.