forgejo/act
11
4
Fork 7
Code Issues 6 Pull requests 2 Actions Releases Activity

WIP: add more verbose workflow validation before parsing #36

Draft
thefox wants to merge 1 commit from thefox/act:integrate_actionlint into main
pull from: thefox/act:integrate_actionlint
merge into: forgejo:main
Conversation 2 Commits 1 Files changed 18 +239 -19
thefox commented 2024-03-25 20:46:52 +00:00
Member
Copy link

Use actionlint to validate workflow before parsing it.

This will enable more verbose errors in forgejo.

Fixes: https://codeberg.org/forgejo/forgejo/issues/2187

Use actionlint to validate workflow before parsing it. This will enable more verbose errors in forgejo. Fixes: https://codeberg.org/forgejo/forgejo/issues/2187
thefox added 1 commit 2024-03-25 20:46:52 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 6m18s
Details
1c0fa68d91
add actionlint check before parsing
earl-warren commented 2024-03-26 06:26:11 +00:00
Owner
Copy link

Are the tests data you added used by this test? I'm asking because only a limited number of tests are run in this CI. It is perfectly ok to add more, only changes done here have not yet required more.

Are the tests data you added used [by this test](https://code.forgejo.org/forgejo/act/actions/runs/165#jobstep-7-62)? I'm asking because only a limited number of tests are run in this CI. It is perfectly ok to add more, only changes done here have not yet required more.
thefox commented 2024-03-26 08:14:28 +00:00
Author
Member
Copy link

They are. in tests I only added on key, since actionlint requires it and the new addition is the workflow from the forgejo issue to prevent potential regressions. Though I'm not certain sure if I shouldn't move actionlint pass to forgejo itself...

They are. in tests I only added `on` key, since actionlint requires it and the new addition is the workflow from the forgejo issue to prevent potential regressions. Though I'm not certain sure if I shouldn't move actionlint pass to forgejo itself...
👍 1
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 6m18s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u integrate_actionlint:thefox-integrate_actionlint
git checkout thefox-integrate_actionlint

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff thefox-integrate_actionlint
git checkout main
git merge --ff-only thefox-integrate_actionlint
git checkout thefox-integrate_actionlint
git rebase main
git checkout main
git merge --no-ff thefox-integrate_actionlint
git checkout main
git merge --squash thefox-integrate_actionlint
git checkout main
git merge --ff-only thefox-integrate_actionlint
git checkout main
git merge thefox-integrate_actionlint
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/act#36
No description provided.
Delete branch "thefox/act:integrate_actionlint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?