forgejo/lxc-helpers
13
2
Fork 2
Code Issues 8 Pull requests 3 Actions Activity

Install helm and forgejo helm chart for k8s tests #16

Merged
earl-warren merged 8 commits from Xinayder/forgejo-lxc-helpers:k3s into main 2023-12-07 14:54:16 +00:00
Conversation 1 Commits 8 Files changed 1 +27 -2
Xinayder commented 2023-12-02 17:03:23 +00:00
Member
Copy link

This pull request improves the existing k8s tests by installing Helm and the Forgejo Helm chart, then checks if it's running by querying the API endpoint for the instance version.

I think there's room for improvement on the port-forward part, maybe it's possible to setup a fixed host IP or have it automatic so we don't need to send the port-forward to the background.

This pull request improves the existing k8s tests by installing Helm and the Forgejo Helm chart, then checks if it's running by querying the API endpoint for the instance version. I think there's room for improvement on the port-forward part, maybe it's possible to setup a fixed host IP or have it automatic so we don't need to send the port-forward to the background.
Xinayder added 1 commit 2023-12-02 17:03:24 +00:00
All checks were successful
/ cascade (pull_request) Successful in 10s
Details
/ test (pull_request) Successful in 13m50s
Details
86080d2306 Install helm and forgejo helm chart for k8s tests
earl-warren requested changes 2023-12-02 17:08:35 +00:00
lxc-helpers-lib-test.sh Outdated
@ -190,0 +204,4 @@
curl -X 'GET' \
-H 'Accept: application/json' \
'http://localhost:3000/api/v1/version'
earl-warren commented 2023-12-02 17:07:23 +00:00
Owner
Copy link

I suggest you echo SUCCESS here and it will never run if the above fails (because of -e)

I suggest you `echo SUCCESS` here and it will never run if the above fails (because of -e)
Xinayder marked this conversation as resolved
lxc-helpers-lib-test.sh Outdated
@ -190,3 +207,4 @@
EOF
lxc_container_run_script $name /usr/local/bin/script.sh | tee $TMP_DIR/script.output
grep --quiet 'Starting k3s' $TMP_DIR/script.output
earl-warren commented 2023-12-02 17:08:30 +00:00
Owner
Copy link

and you grep --quiet 'SUCCESS' $TMP_DIR/script.output here which will be straightforward to relate to the above echo, IMHO.

and you `grep --quiet 'SUCCESS' $TMP_DIR/script.output` here which will be straightforward to relate to the above echo, IMHO.
Xinayder marked this conversation as resolved
Xinayder added 1 commit 2023-12-02 19:27:05 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Failing after 7m42s
Details
5e06b8a270 Try to fix oport forwarding not working
Xinayder added 1 commit 2023-12-02 20:27:41 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Failing after 7m23s
Details
bfe7cf8fe9 Fix wrong env var for k3s install script
Xinayder added 1 commit 2023-12-02 20:37:19 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Failing after 6m16s
Details
1d7e10324c Add debug commands to help figure out what's up with port forward
Xinayder added 1 commit 2023-12-02 20:46:10 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Failing after 7m24s
Details
8b801dc60a Set clusterIP to empty string instead of empty array
Xinayder added 1 commit 2023-12-02 21:10:44 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Successful in 13m25s
Details
4ecedbdd09 Change service type to LoadBalancer
earl-warren approved these changes 2023-12-02 22:38:50 +00:00
earl-warren commented 2023-12-02 22:45:20 +00:00
Owner
Copy link

Ready to merge when you are.

Ready to merge when you are.
Xinayder changed title from WIP: Install helm and forgejo helm chart for k8s tests to Install helm and forgejo helm chart for k8s tests 2023-12-07 13:48:48 +00:00
Xinayder force-pushed k3s from 4ecedbdd09 to a279ed92b0 2023-12-07 13:48:57 +00:00 Compare
Xinayder added 1 commit 2023-12-07 14:25:00 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
/ test (pull_request) Failing after 6m16s
Details
9087bde72f Show chart info before installing Forgejo Helm chart
Xinayder added 1 commit 2023-12-07 14:37:58 +00:00
All checks were successful
/ test (pull_request) Successful in 13m38s
Details
/ cascade (pull_request) Has been skipped
Details
43371a9606 Use Helm chart version 0.15 due to regression
earl-warren merged commit eb33106637 into main 2023-12-07 14:54:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: forgejo/lxc-helpers#16
No description provided.
Delete branch "Xinayder/forgejo-lxc-helpers:k3s"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?