IPv6 tests #129
No reviewers
Labels
No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: forgejo/runner#129
Loading…
Reference in a new issue
No description provided.
Delete branch "earl-warren/runner:wip-ipv6"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
7bbb083848
to2113010839
2113010839
to82e7903cf6
82e7903cf6
todfa5b40d08
dfa5b40d08
to6601916845
6601916845
to5657be456b
5657be456b
toc7f32c976f
c7f32c976f
to0d7c611eef
0d7c611eef
to226bf636e6
@s3lph an extra pair of eyes would be much appreciated here. My biggest concern in this kind of tests is false positive.
cascading-pr updated at actions/setup-forgejo#107
@ -0,0 +8,4 @@
steps:
- run: |
apt update -qq ; apt --quiet install -qq --yes iputils-ping
ping -c 1 -6 ::1
Do you want to verify whether the Forgejo Runner creates its networks with
enable_ipv6
: true? Or do you want to take it a step further and verify that IPv6 connectivity including ip6tables NAT actually works.This localhost ping check suffices to do the former, but to achieve the latter, either a ping or (IMO better, as it also works with unprivileged Podman containers) curl to a public IPv6-only server such as ipv6.google.com is needed. An example for this can be found in my docs PR.
In this context, I think the simpler test is good enough as it demonstrates IPv6 is enabled. For the other part, the daemon, it is best done in the setup-forgejo tests because they provide the context where forgejo is also setup and can be configured / reconfigured in various ways for test purposes.
The documentation you wrote is the guide I follow.
For the record it is not possible to test external routing because there appears to be a bug in how IPv6 is supported in Debian LXC containers. For the purpose of verifying IPv6 is available in a workflow this is not strictly necessary although it would be a bonus.
226bf636e6
to39e0d5b161
569a8d5a2c
tod7e471a392