upload-artifact@v4 does not work #144

Closed
opened 2024-01-19 12:21:03 +00:00 by earl-warren · 14 comments
Owner
https://code.forgejo.org/actions/upload-artifact@v4 does not work but https://code.forgejo.org/actions/upload-artifact@v3 does, as [reported in this issue](https://code.forgejo.org/actions/upload-artifact/issues/1). https://github.com/go-gitea/gitea/pull/28965 has a good high level view of the work involved.
earl-warren added the
Kind/Bug
label 2024-01-19 12:21:03 +00:00
Author
Owner

See https://github.com/nektos/act/issues/2135

Research about actions/upload-artifact@v4 and actions/download-artifact@v4

See https://github.com/nektos/act/issues/2135 > Research about actions/upload-artifact@v4 and actions/download-artifact@v4
Author
Owner

@f00 FYI

@f00 FYI
Author
Owner
See also https://github.com/go-gitea/gitea/pull/28885
Author
Owner
See also https://gitea.com/gitea/act_runner/pulls/473
Author
Owner
https://github.com/go-gitea/gitea/pull/28965 sits on top of https://github.com/go-gitea/gitea/pull/28885
Author
Owner

See also https://github.com/go-gitea/gitea/pull/28885

Forgejo v1.22 will include support required for that to work. Tests should be added before it is released.

> See also https://github.com/go-gitea/gitea/pull/28885 Forgejo v1.22 will include support required for that to work. Tests should be added before it is released.
Author
Owner

https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good.

https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good.

https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good.

It's been merged.

> https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good. It's been merged.

Time to cherry pick it into forgejo @earl-warren, to bring upload-artifact@v4 to a reality!

Time to cherry pick it into forgejo @earl-warren, to bring upload-artifact@v4 to a reality!
Author
Owner

#156 should do it runner side.

https://code.forgejo.org/forgejo/runner/pulls/156 should do it runner side.
Author
Owner

https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good.

It's been merged.

It is in Forgejo as of last week.

> > https://github.com/go-gitea/gitea/pull/28965/files still being worked on (last activity this week). Progress is good. > > It's been merged. It is in Forgejo as of last week.
Author
Owner

Reminder to close this issue once it has been confirmed to work with the upcoming release of the runner 3.4.0, either because an automated test was added to end-to-end or because someone reports it working manually.

Reminder to close this issue once it has been confirmed to work with the upcoming release of the runner 3.4.0, either because an automated test was added to end-to-end or because someone reports it working manually.
Author
Owner

https://code.forgejo.org/forgejo/end-to-end/pulls/121/files verifies it works (tested locally and requires Forgejo 7.0+ and Forgejo runner 3.4+, will be in the CI from now on), with the caveat that it needs a forked version of the action that claims to not be GHES. These forked versions are advertised in the comment of the mirror at:

and they are made available at:

I made a note to check them in two months from now: the fork is likely to not be necessary once the protocol is supported by GHES which will happen eventually.

https://code.forgejo.org/forgejo/end-to-end/pulls/121/files verifies it works (tested locally and requires Forgejo 7.0+ and Forgejo runner 3.4+, will be in the CI from now on), with the caveat that it needs a forked version of the action that claims to **not** be GHES. These forked versions are advertised in the comment of the mirror at: * https://code.forgejo.org/actions/upload-artifact * https://code.forgejo.org/actions/download-artifact and they are made available at: * https://code.forgejo.org/forgejo/upload-artifact/src/tag/v4 * https://code.forgejo.org/forgejo/download-artifact/src/tag/v4 I [made a note](https://code.forgejo.org/forgejo/runner/issues/159) to check them in two months from now: the fork is likely to not be necessary once the protocol is supported by GHES which will happen eventually.
Author
Owner
Fixed in https://code.forgejo.org/forgejo/runner/releases/tag/v3.4.0
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#144
No description provided.