bug: [actions/upload-artifact] wrong artifact-id and artifact-url

f00 commented

2024-05-02 21:46:44 +00:00

The action upload-artifact provides two outputs:

artifact-url
artifact-id

The URL will construct the following way:

const artifactURL = `${github.context.serverUrl}/${repository.owner}/${repository.repo}/actions/runs/${github.context.runId}/artifacts/${uploadResponse.id}`

So, runId and uploadResponse.id is used. runID comes from the runner itself(?)

runner.go:

...
	preset := &model.GithubContext{
		Event:           taskContext["event"].GetStructValue().AsMap(),
		RunID:           taskContext["run_id"].GetStringValue(),
		RunNumber:       taskContext["run_number"].GetStringValue(),
...

This results in the following artifact-url (output), which is broken (HTTP 404):

https://<host>/<user>/<project>/actions/runs/162/artifacts/58

The correct artifact-url (taken from the Web-UI) should be the following:

https://<host>/<user>/<project>/actions/runs/47/artifacts/website-content

This is my runner workflow:

jobs:
  build:
    runs-on: docker
    outputs:
      artifacturl: ${{ steps.artifact-upload.outputs.artifact-url }}
      artifactid: ${{ steps.artifact-upload.outputs.artifact-id }}
    steps:
...
      - name: Build artifact
        id: artifact-upload
        uses: https://code.forgejo.org/forgejo/upload-artifact@v4
        with:
          name: website-content
          path: /...
  deploy:
    runs-on: self-hosted
    needs: build
    steps:
      - name: Deploy
        env:
          ARTIFACT_URL: ${{needs.build.outputs.artifacturl}}
          ARTIFACT_ID: ${{needs.build.outputs.artifactid}}
        run: |
          echo $ARTIFACT_URL
          echo $ARTIFACT_ID

It looks like github is using a different URI then forgejo. RunID should be the RunNumber and the artifact-id should be the name of the artifact rather than an ID.

The action ```upload-artifact``` provides two outputs: * artifact-url * artifact-id The URL will construct the following way: ``` const artifactURL = `${github.context.serverUrl}/${repository.owner}/${repository.repo}/actions/runs/${github.context.runId}/artifacts/${uploadResponse.id}` ``` So, ```runId``` and ```uploadResponse.id``` is used. runID comes from the runner itself(?) runner.go: ``` ... preset := &model.GithubContext{ Event: taskContext["event"].GetStructValue().AsMap(), RunID: taskContext["run_id"].GetStringValue(), RunNumber: taskContext["run_number"].GetStringValue(), ... ``` This results in the following artifact-url (output), which is broken (HTTP 404): ``` https://<host>/<user>/<project>/actions/runs/162/artifacts/58 ``` The correct artifact-url (taken from the Web-UI) should be the following: ``` https://<host>/<user>/<project>/actions/runs/47/artifacts/website-content ``` This is my runner workflow: ``` jobs: build: runs-on: docker outputs: artifacturl: ${{ steps.artifact-upload.outputs.artifact-url }} artifactid: ${{ steps.artifact-upload.outputs.artifact-id }} steps: ... - name: Build artifact id: artifact-upload uses: https://code.forgejo.org/forgejo/upload-artifact@v4 with: name: website-content path: /... deploy: runs-on: self-hosted needs: build steps: - name: Deploy env: ARTIFACT_URL: ${{needs.build.outputs.artifacturl}} ARTIFACT_ID: ${{needs.build.outputs.artifactid}} run: | echo $ARTIFACT_URL echo $ARTIFACT_ID ``` It looks like github is using a different URI then forgejo. ```RunID``` should be the ```RunNumber``` and the ```artifact-id``` should be the name of the artifact rather than an ID.

earl-warren added the

Kind/Bug

label

2024-05-03 07:21:31 +00:00

earl-warren referenced this issue

2024-05-03 07:22:11 +00:00

chore: is the {upload,download}-artifact@v4 fork still necessary? #159

f00 referenced this issue

2024-05-03 10:18:11 +00:00

chore: is the {upload,download}-artifact@v4 fork still necessary? #159

f00 commented

2024-05-28 12:53:11 +00:00

Author

Any update on this?
@earl-warren: Do I miss something here?

Any update on this? @earl-warren: Do I miss something here?

earl-warren commented

2024-05-28 13:25:07 +00:00

Contributor

No update, you did not miss anything. This needs work.

👍 1

earl-warren added the

Reviewed

Confirmed

label

2024-06-07 07:43:34 +00:00

f00 referenced this issue

2024-06-07 12:01:15 +00:00

chore: is the {upload,download}-artifact@v4 fork still necessary? #159

earl-warren changed title from ~~[actions/upload-artifact] Wrong artifact-id and artifact-url~~ to bug: [actions/upload-artifact] wrong artifact-id and artifact-url

2025-07-01 15:41:50 +00:00

earl-warren added the

Priority

Medium

label

2025-07-11 12:34:20 +00:00

earl-warren commented

2025-08-17 09:47:17 +00:00

Contributor

I'll work on fixing that now.

❤️ 1

earl-warren commented

2025-08-17 11:36:45 +00:00

Contributor

I looked up Gitea but this is not implemented either, it 404 exactly in the same way.

earl-warren commented

2025-08-17 11:44:10 +00:00

Contributor

I tried my best to find code to cherry-pick and not re-invent an existing solution. Since there is nothing, I'll happily get creative on this one 😁

earl-warren commented

2025-08-17 17:33:37 +00:00

Contributor

@f00 your investigation was useful and the conclusions correct. The fixes are:

@f00 your investigation was useful and the conclusions correct. The fixes are: - https://codeberg.org/forgejo/forgejo/pulls/8957 - https://codeberg.org/forgejo/forgejo/pulls/9023

❤️ 1

earl-warren referenced this issue from a commit

2025-08-17 17:38:12 +00:00

fix: the run id is meant to be relative to the repository

f00 commented

2025-08-23 08:27:51 +00:00

Author

Thats awesome! Thank you!

forgejo-mirror referenced this issue from a commit

2025-08-25 14:01:11 +00:00

feat: artifacts can be downloaded using their id instead of their name (#8957)

earl-warren commented

2025-08-27 07:46:18 +00:00

Contributor

It turned out to require a breaking change (a minor one but still). https://codeberg.org/forgejo/forgejo/pulls/9023 will be where it happens. @f00 if you could take a look at it (specially the release note part) it would be much appreciated.

forgejo-mirror referenced this issue from a commit

2025-08-27 17:01:31 +00:00

fix!: use run ID instead of run Index in artifacts download web views

earl-warren closed this issue

2025-08-27 21:12:51 +00:00

earl-warren referenced this issue

2025-09-01 22:13:58 +00:00

bug: upload-artifact shows wrong download URL in output? #926

Rows
Columns

bug: [actions/upload-artifact] wrong artifact-id and artifact-url #187