forgejo/runner
11
29
Fork 21
Code Issues 38 Pull requests 1 Actions Packages Releases 26 Activity

Fix the Docker entrypoint #67

Merged
earl-warren merged 2 commits from wetneb/runner:66-docker-entrypoint into main 2023-08-18 10:03:05 +00:00
Conversation 3 Commits 2 Files changed 1 +3 -2
wetneb commented 2023-08-13 12:22:04 +00:00
Contributor
Copy link

For #66, untested.

For #66, untested.
❤️ 1
wetneb added 1 commit 2023-08-13 12:22:07 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 58s
Details
8ecb7dd9c3 Attempt to fix the Docker entrypoint, for #66
dachary commented 2023-08-13 13:10:20 +00:00
Member
Copy link
$ docker run --rm alpine:3.18 /sbin/tini
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/sbin/tini": stat /sbin/tini: no such file or directory: unknown.

This is https://github.com/krallin/tini I suppose? Did not know about it. Seems good.

``` $ docker run --rm alpine:3.18 /sbin/tini docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/sbin/tini": stat /sbin/tini: no such file or directory: unknown. ``` This is https://github.com/krallin/tini I suppose? Did not know about it. Seems good.
wetneb added 1 commit 2023-08-13 15:00:23 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 35s
Details
cbffc7e8c8 Add 'tini' to the apk packages of the Dockerfile
earl-warren commented 2023-08-18 06:58:56 +00:00
Owner
Copy link

@wetneb still wip?

@wetneb still wip?
wetneb changed title from WIP: Fix the Docker entrypoint to Fix the Docker entrypoint 2023-08-18 09:47:45 +00:00
wetneb commented 2023-08-18 09:47:59 +00:00
Author
Contributor
Copy link

@earl-warren it's good to go on my side.

@earl-warren it's good to go on my side.
earl-warren approved these changes 2023-08-18 10:02:53 +00:00
earl-warren merged commit 75687152e9 into main 2023-08-18 10:03:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#67
No description provided.
Delete branch "wetneb/runner:66-docker-entrypoint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?