forgejo/runner
11
29
Fork 20
Code Issues 35 Pull requests 1 Actions Packages Releases 26 Activity

add combined labels back to registry #176

Merged
earl-warren merged 5 commits from thefox/runner:label_loading_patch into main 2024-04-10 22:47:37 +00:00
Conversation 1 Commits 5 Files changed 4 +48
thefox commented 2024-04-07 09:39:20 +00:00
Member
Copy link

potential fix for #174

potential fix for #174
thefox added 1 commit 2024-04-07 09:39:21 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Successful in 57s
Details
checks / runner exec tests (pull_request) Successful in 52s
Details
/ example-docker-compose (pull_request) Successful in 2m21s
Details
abc9bf653a
after reading labels, load them into registration
earl-warren added the
Kind/Bug
 label 2024-04-09 10:35:08 +00:00
thefox added 1 commit 2024-04-09 18:53:36 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Successful in 54s
Details
checks / runner exec tests (pull_request) Successful in 47s
Details
/ example-docker-compose (pull_request) Successful in 2m30s
Details
ac7d0ce703
add label change post runner creation
thefox added 1 commit 2024-04-10 20:40:09 +00:00
Some checks failed
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Failing after 1m0s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
/ example-docker-compose (pull_request) Successful in 2m6s
Details
67fe3f7d4a
added simple test to label update
thefox commented 2024-04-10 20:45:33 +00:00
Author
Member
Copy link

@earl-warren I've added a test to this. Took a while because I wanted to check daemon rather than runner but this is better than nothing. We can go with this for now unless you have idea how to check the actual daemon function for this.

@earl-warren I've added a test to this. Took a while because I wanted to check daemon rather than runner but this is better than nothing. We can go with this for now unless you have idea how to check the actual daemon function for this.
earl-warren reviewed 2024-04-10 21:01:20 +00:00
internal/app/run/runner_test.go Outdated
@ -0,0 +13,4 @@
ls := labels.Labels{}
initialLabel, err := labels.Parse("testlabel:docker://alpine")
assert.Nil(t, err)
earl-warren commented 2024-04-10 21:01:20 +00:00
Owner
Copy link

NoError is more idiomatic than Nil

`NoError` is more idiomatic than `Nil`
thefox marked this conversation as resolved
thefox added 1 commit 2024-04-10 21:21:50 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Successful in 1m2s
Details
checks / runner exec tests (pull_request) Successful in 48s
Details
/ example-docker-compose (pull_request) Successful in 2m30s
Details
af1fe86440
replace Nil with NoError
earl-warren requested changes 2024-04-10 21:43:59 +00:00
Dismissed
earl-warren left a comment
Owner
Copy link

An addition to the release notes and good to merge.

An addition to the release notes and good to merge.
thefox force-pushed label_loading_patch from af1fe86440 to bcfea8f688 2024-04-10 21:52:36 +00:00 Compare
thefox force-pushed label_loading_patch from bcfea8f688 to 5539ef7275 2024-04-10 21:56:03 +00:00 Compare
thefox requested review from earl-warren 2024-04-10 22:03:44 +00:00
earl-warren approved these changes 2024-04-10 22:10:14 +00:00
earl-warren merged commit 5e51d8ed42 into main 2024-04-10 22:47:37 +00:00
earl-warren deleted branch label_loading_patch 2024-04-10 22:47:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#176
No description provided.
Delete branch "thefox/runner:label_loading_patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?