forgejo/runner
12
29
Fork 21
Code Issues 38 Pull requests 1 Actions Packages Releases 26 Activity

fix: labels from config.yml take precedence #178

Closed
earl-warren wants to merge 1 commit from earl-warren/runner:wip-config into main
pull from: earl-warren/runner:wip-config
merge into: forgejo:main
Conversation 3 Commits 1 Files changed 5 +46 -7
earl-warren commented 2024-04-09 10:25:43 +00:00
Owner
Copy link

Fixes: #174

Fixes: https://code.forgejo.org/forgejo/runner/issues/174
earl-warren added the
Kind/Bug
 label 2024-04-09 10:25:43 +00:00
earl-warren added 1 commit 2024-04-09 10:25:44 +00:00
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / build and test (pull_request) Successful in 57s
Details
checks / runner exec tests (pull_request) Successful in 39s
Details
/ example-docker-compose (pull_request) Successful in 4m7s
Details
43a8a402f4
fix: labels from config.yml take precedence 
Fixes: #174
earl-warren requested review from thefox 2024-04-09 10:26:11 +00:00
earl-warren commented 2024-04-09 10:34:21 +00:00
Author
Owner
Copy link

It is essentially the same as https://code.forgejo.org/forgejo/runner/pulls/176/files which I overlooked, sorry about that 😊

It is essentially the same as https://code.forgejo.org/forgejo/runner/pulls/176/files which I overlooked, sorry about that 😊
earl-warren changed title from fix: labels from config.yml take precedence to WIP: fix: labels from config.yml take precedence 2024-04-09 10:38:54 +00:00
earl-warren commented 2024-04-09 10:40:15 +00:00
Author
Owner
Copy link

A unit test is needed for this PR, switching to WIP:.

@thefox since you filed your PR first I'll defer to your decision. Would you like to add a test to yours or should I add a test to mine? I really should be more careful before opening new PRs.

A unit test is needed for this PR, switching to WIP:. @thefox since you filed your PR first I'll defer to your decision. Would you like to add a test to yours or should I add a test to mine? I really should be more careful before opening new PRs.
earl-warren force-pushed wip-config from 43a8a402f4 to 868989a0a0 2024-04-09 13:39:29 +00:00 Compare
earl-warren changed title from WIP: fix: labels from config.yml take precedence to fix: labels from config.yml take precedence 2024-04-09 13:39:53 +00:00
earl-warren commented 2024-04-09 18:58:44 +00:00
Author
Owner
Copy link

Closing in favor of #176

Closing in favor of https://code.forgejo.org/forgejo/runner/pulls/176
earl-warren closed this pull request 2024-04-09 18:58:44 +00:00
All checks were successful
checks / build and test (pull_request) Successful in 53s
Details
checks / runner exec tests (pull_request) Successful in 42s
Details
/ example-docker-compose (pull_request) Successful in 4m39s
Details
/ cascade (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
thefox
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: forgejo/runner#178
No description provided.
Delete branch "earl-warren/runner:wip-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?